Expand option

[mbab]

Here is proposition to rework of 4 levels of expand option
0 = All - no changes here
1 = No common prayers (as Pater, Deus in adjutorium), but keep whole Dómine Deus omnípotens, Respice, etc.
2 = as above + psalm numbers and readings source or title for non biblical instead of full text
3 = Skeleton - no changes here

[APMarcello3]

I propose the term "lineamenta" in lieu of "skeleton".

[FAJ-Munich]

as of now, the Expansion of the &psalm(50) popup links do not work yet again. Not sure why.

For the Option 1: At the moment, the algorithm decided to not expand $reference starting with a Capital letter, keeping starting with miniscule (with the exception of pater_noster: (cf. horascommon.plline 2119:

 # Make popup link if we shouldn't expand.
    if ($expand =~ /none/i
      || ($expand !~ /all|skeleton/i && ($line =~ /^(?:[A-Z]|pater_noster)/)))
    {
      return setlink($sigil . $line, 0, $lang);
    }

I guess there could be a better logic to differentiate proper "Common Prayers"

[FAJ-Munich]

With the exception of implementing the "extraction of the readings titles" for &lectio(1) references, I have implemented the reworking you have proposed in this branch: https://github.com/FAJ-Munich/divinum-officium/tree/display-sep-626

The expansions are:

• tota : replacing the old all (no changes)
• psalteria : no common prayers but the rest of the Psalterium is expanded (replacing the old psalmi)
• propria : only expanding the propers and all of the rubrics which are applying, e.g., to un-expanded common prayers
• lineamenta : replacing the skeleton (no changes) as per Father's suggestion

@mbab Could you, as time permits, double check if I missed out something? +LJCh+

[mbab]

@FAJ-Munich
- sign in psalm numbering in propria looks strange
Eg. In 10-21-2024 Tridentine

also this (but have no ideo what to do with it)

There should by way to remove empty cells from below lineamenta

[FAJ-Munich]

Dziękuję bardzo za szybką recenzję!

-sign ...
`Psalm(231)

agreed. These need to be addressed alongside the meaningless &lectio(1) etc.; haven't had enough time to finish by yesterday evening.

There should be a way to remove ...

I'll give it a try.

[FAJ-Munich]

Have rebased and force pushed my branch including the suggested implementations.
If there are no objections I would open PR?

[APMarcello3]

[FAJ-Munich]

fixed by #4124