Apply equation changes and some comments. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldgaetano
changed the base branch from
main
to
develop/gluon-contract-and-backend-fix
kii-dot
reviewed
Jan 3, 2024
| @@ -758,15 +754,14 @@ | |||
| // ** Fusion Ratio ** | |||
| // min(q*, (SNeutrons * Pt / R)) | |||
| // where q* is a constant, Pt is the price of gold in Ergs. | |||
| // The steps of multiplication and division done below are to avoid overflow errors. | |||
There was a problem hiding this comment.
you say its to avoid overflow, are there tests that can test this in the off-chain code? Just to make sure we cover some edge cases
There was a problem hiding this comment.
No, I did not make tests for it. I did a math calculation by hand assuming worst case scenario (i.e. largest possible values given the chosen protocol paramters) to determine how to do the divisions. I guess it would be good to do tests for that though.
There was a problem hiding this comment.
can you write one quick test for it. Dont need to be extensive. Just something so that we have reference for what the worst case scenario would be. After that its good to merge
ceilican
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes to the fusion reaction equation and added some comments for better readability.
I noticed error upon revision of the beta+/- reaction, so corrected the calculation, please review this.
Fixes #6
Type of change
How Has This Been Tested?
I ran all tests and all passed except for the GluonWFeesSpec, however the error is unrelated to anything I changed, so it might have been there before I changed anything.
To be composed in the future
Applying corresponding changes to the backend code.
Checklist: