Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #6 - Add Submission Instructions to README #7

Closed
wants to merge 1 commit into from
Closed

Closes #6 - Add Submission Instructions to README #7

wants to merge 1 commit into from

Conversation

zmckinnon
Copy link
Contributor

@zmckinnon zmckinnon commented Apr 24, 2020 •
edited
Loading

Resolves #6

We still need to:

  • Create a slack channel with the appropriate people
  • Setup the GitHub/Slack integration so that we know when PRs are opened.

A couple of things here:

  • Eventually, we will have lots of forks/Pull Requests and technically people could "cheat". This might be a problem, I dunno.
  • How the tests are being submitted pretty much bypasses recruiting. I am not sure if that's a great idea.
  • dndbeyond-dev is essentially a Service Account for our team and not really tied to any particular person. We'd be super dependent on the Slack notification.

@zmckinnon zmckinnon added the documentation Improvements or additions to documentation label Apr 24, 2020
@zmckinnon zmckinnon self-assigned this Apr 24, 2020
@zmckinnon zmckinnon changed the title #6 Add Submission Instructions to README Closes #6 - Add Submission Instructions to README Apr 24, 2020
@theavish
Copy link

Eventually, we will have lots of forks/Pull Requests and technically people could "cheat". This might be a problem, I dunno.

in my experience, people keep the repo private and then create forks for each candidate

@zmckinnon zmckinnon closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irtriskit irtriskit irtriskit approved these changes

@doneholmes doneholmes Awaiting requested review from doneholmes

Assignees

@zmckinnon zmckinnon

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Submission Instructions
3 participants
@zmckinnon @theavish @irtriskit