You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 29, 2021. It is now read-only.
campaign_run_id: (int) optional. The drupal campaign run node id of the campaign that the user's post is associated with.
This item specifying the campaign_run_id as optional needs to be updated to indicate that it is required if the campaign_id is a Drupal ID.
One thing to note is that the campaign_id value can be either an integer or a string... and the Drupal ID can apparently be either (362 or "362"), but I doubt that's the case for the campaign_run_id. So I think it would make sense to also update the docs to specify that the campaign_id should be an int if a Drupal ID or a string if a Contentful ID. Thoughts?
The text was updated successfully, but these errors were encountered:
I believe we're just checking if it's numeric or not (/[0-9]+/), since even if it's provided by the client as an integer it'd still be casted & stored as a string.
yeah, but then there's inconsistency cause in the scenario of the Drupal ID I could pass the campaign_id as a string but for the campaign_run_id it needs to be an integer. Maybe just update the campaign_run_id to accept both as well?
Same deal there I believe, Laravel's integer validator will just check if the provided value can be used as an integer (whether it's provided as a string or integer in the JSON body).
DOCUMENTATION
Affected Pages
Create a Post
Explanation
This item specifying the
campaign_run_id
as optional needs to be updated to indicate that it is required if thecampaign_id
is a Drupal ID.One thing to note is that the
campaign_id
value can be either an integer or a string... and the Drupal ID can apparently be either (362
or"362"
), but I doubt that's the case for thecampaign_run_id
. So I think it would make sense to also update the docs to specify that thecampaign_id
should be anint
if a Drupal ID or astring
if a Contentful ID. Thoughts?The text was updated successfully, but these errors were encountered: