-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX add constant to avoid price error when TTC is price base type #32869
base: 20.0
Are you sure you want to change the base?
Conversation
@eldy maybe remove the possibility to set content of TTC field with ajax return ? |
@eldy @sonikf here the problem is that if you have a product with a price defined in TTC base with a VAT rate of 20% and you sell to an EU or non-EU customer, the HT is not taken into account, the line is recorded in TTC! That's why I tell myself that when we select a defined product, whether it is in TTC or HT base we should always have the HT informed during the selection (ajax return) |
the ajax return should only provide the HT field and not the TTC field |
You are right. Sorry i was lost in translation seeing forum post and didn't realize the price was incl tax thought was different products!!! |
@sonikf yes if there is no exception in the rule 😄 |
Hi, MAIN_NO_INPUT_PRICE_WITH_TAX which one should be set or not set? with MAIN_NO_INPUT_PRICE_WITH_TAX I get only NET price displayed - but get NET and with Tax price on in the PDF This works for B2B but I need the option like before to change to NET + TAX (Brutto) price for private customers |
When a price has been defined to be a price including tax, the prixe must be recorded including tax. And it is the prices without tax that will vary depeding on we add tax or not. I think the trouble is only in edit. When we edit, if the price on product is tax included, the suggested price in form must be with tax, if not,the suggested price must be price without. But currently, we do not save the unit price including tax into the field subprice_ttc (we only fill subprice). So we always suggest the price exluding tax when we edit. This feature was never implemented. So first thing to do is to update code in develop to store the unit price including tax into subprice_ttc when we enter a price including tax. So we are able to autofill the field price including taxt when we edit the line. |
The problem is that there can be two visions of things when we define a price on a tax-inclusive basis. Product Price: 150 including VAT with a rate of 20% Or we can think that when we sell a product with a tax-inclusive base with a VAT rate of 0, then we will have the price excluding VAT in the documents. Product Price: 150 including VAT with a rate of 20% |
@eldy with my PR you can manage the 2 cases : without MAIN_SET_CONTENT_INPUT_PRICE_WITH_TAX_DISABLED = case 1 |
From my Point of View: |
@zeug-it what is the price base type of your customer prices? |
@hregis The base price is the with tax Brutto price |
@zeug-it and if you create an invoice for an UE or not UE with 0% you would brutto or netto prices? |
@hregis for a company customer in EU with TAX ID we create a netto price invoice, because the customer has to pay the tax in his own country. 0% netto price for a company customer in EU without TAX ID we create a brutto price invoice (German Tax), because the customer has to pay the tax in his own country. 19% brutto price invoice for non EU Countries 0% nettp price |
@eldy ok donc il y a un soucis quand un produit a une base de prix ttc et qu'on vend à TVA 0% |
No description provided.