Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX max file size to download not needed for WebPortal #32964

Conversation

lvessiller-opendsi
Copy link
Contributor

FIX max file size to download not needed for WebPortal

  • the file size in not for downloading PDF documents (no limit)

With this FIX it's the same behavior when you download PDF documents from the back office.

@eldy
Copy link
Member

eldy commented Feb 6, 2025

The parameter MAIN_SECURITY_MAXFILESIZE_DOWNLOADED is desgined for download from any public pages or portal (so like the webportal).
It is to avoid some king of cyber attack. The problem is not the option, but the fact that the default value is wrong. No test must be done if option is set to 0.
I pushed a better fix.

eldy added a commit that referenced this pull request Feb 6, 2025
@eldy eldy closed this Feb 6, 2025
@lvessiller-opendsi lvessiller-opendsi deleted the fix-webportal-max-file-size branch February 6, 2025 16:25
lvessiller-opendsi added a commit to Easya-Solutions/dolibarr that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants