Skip to content

Commit e03fa94

Browse files
bavneetsingh16Bavneet Singhatchutbarlivineeth-thummamcnealm13
authored
[connectedk8s] Update extension CLI to v1.10.10 (Azure#9254)
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove redundant test files --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>
1 parent fc5e6bb commit e03fa94

File tree

5 files changed

+25
-6
lines changed

5 files changed

+25
-6
lines changed

‎src/connectedk8s/HISTORY.rst‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
33
Release History
44
===============
5+
1.10.10
6+
+++++
7+
* Deprecated '--app-id' and '--app-secret' RBAC parameters from the extension by adding them to _breaking_change.py.
8+
* Bug fix for https://github.com/Azure/azure-cli-extensions/issues/8498.
9+
* Update warning to use the latest kubelogin version which has support for generating PoP token.
10+
511
1.10.9
612
++++++
713
* Added support for associating and disassociating gateways in CLI and updated SDK version to '2025-08-01-preview'.
@@ -78,7 +84,7 @@ Release History
7884
++++++
7985
* New api version 2024-07-1-preview added
8086
* Adding functionality for workload identity feature.
81-
* Cluster create and update waits for agent state
87+
* Cluster create and update waits for agent state
8288

8389
1.7.3
8490
++++++

‎src/connectedk8s/azext_connectedk8s/_breaking_change.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# --------------------------------------------------------------------------------------------
2+
# Copyright (c) Microsoft Corporation. All rights reserved.
3+
# Licensed under the MIT License. See License.txt in the project root for license information.
4+
# --------------------------------------------------------------------------------------------
5+
from azure.cli.core.breaking_change import register_argument_deprecate
6+
7+
register_argument_deprecate("connectedk8s enable-features", "--app-id")
8+
register_argument_deprecate("connectedk8s enable-features", "--app-secret")

‎src/connectedk8s/azext_connectedk8s/_utils.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,10 +1056,10 @@ def arm_exception_handler(
10561056
status_code = ex.status_code
10571057
if status_code == 404 and return_if_not_found:
10581058
return
1059-
if status_code is not None and status_code // 100 == 4:
1059+
if status_code and status_code // 100 == 4:
10601060
telemetry.set_user_fault()
10611061
telemetry.set_exception(exception=ex, fault_type=fault_type, summary=summary)
1062-
if status_code is not None and status_code // 100 == 5:
1062+
if status_code and status_code // 100 == 5:
10631063
raise AzureInternalError(
10641064
"Http response error occured while making ARM request: "
10651065
+ str(ex)

‎src/connectedk8s/azext_connectedk8s/custom.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2993,6 +2993,10 @@ def enable_features(
29932993
utils.check_features_to_update(features)
29942994
)
29952995

2996+
# Initialize these variables to ensure they are always defined, preventing UnboundLocalError if only a subset of features is enabled.
2997+
final_enable_cl = False
2998+
custom_locations_oid = None
2999+
29963000
# Check if cluster is private link enabled
29973001
connected_cluster = client.get(resource_group_name, cluster_name)
29983002

@@ -3152,8 +3156,9 @@ def enable_features(
31523156
# apps for authN/authZ.
31533157
cmd_helm_upgrade.extend(["--set", "systemDefaultValues.guard.authnMode=arc"])
31543158
logger.warning(
3155-
"Please use the kubelogin version v0.0.32 or higher which has support for generating PoP token(s). "
3156-
"This is needed by guard running in 'arc' authN mode."
3159+
"[Azure RBAC] For secure authentication, ensure you have the latest kubelogin installed which supports PoP tokens. "
3160+
"This is required for Azure RBAC. Download or upgrade at: https://github.com/Azure/kubelogin/releases. "
3161+
"If you encounter authentication errors, please verify your kubelogin version and refer to the documentation: https://learn.microsoft.com/en-us/azure/azure-arc/kubernetes/azure-rbac"
31573162
)
31583163
cmd_helm_upgrade.extend(
31593164
[

‎src/connectedk8s/setup.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# TODO: Confirm this is the right version number you want and it matches your
1414
# HISTORY.rst entry.
1515

16-
VERSION = "1.10.9"
16+
VERSION = "1.10.10"
1717

1818
# The full list of classifiers is available at
1919
# https://pypi.python.org/pypi?%3Aaction=list_classifiers

0 commit comments

Comments
 (0)