Replies: 4 comments 7 replies
-
|
How do you define large data collections ? ;-) |
Beta Was this translation helpful? Give feedback.
-
|
I did a quick test with a very simple HTML and Javascript and it renders 5000 record rows super fast <html>
<body>
<table>
<thead>
<tr>
<th>name</th>
<th>code</th>
</tr>
</thead>
<tbody id="s-tbody">
</tbody>
</table>
<script type="application/javascript">
let tbody = document.getElementById("s-tbody");
for (let i = 0; i< 5000; i++){
let tr = document.createElement("tr");
tbody.appendChild(tr)
let name = document.createElement("td");
name.textContent = "name - "+i;
let code = document.createElement("td");
code.textContent = "code - "+i;
tr.appendChild(name);
tr.appendChild(code);
}
</script>
</body>
</html>I dont want the exact same performance for 5000 records because we knew in an actual rich datatable it is not that simple, but I want to make it reasonable fast and make sure that we are not just missing on something that is slowing things down. |
Beta Was this translation helpful? Give feedback.
-
|
Can this also be investigated for Select with many objects. |
Beta Was this translation helpful? Give feedback.
-
|
I just did a quick test public class App implements EntryPoint {
/**
* This is the entry point method.
*/
public void onModuleLoad() {
var layout = Layout.create("Domino-ui starter")
.show(ColorScheme.BLUE);
List<City> cities = new ArrayList<>();
for(int i=0; i<5000;i++){
cities.add(new City("name - "+i, "code - "+i));
}
TableConfig<City> tableConfig = new TableConfig<City>()
.addColumn(ColumnConfig.<City>create("name", "Name")
.setCellRenderer(cellInfo -> DominoElement.div().appendChild(TextNode.of(cellInfo.getRecord().getName())).element())
)
.addColumn(ColumnConfig.<City>create("code", "code")
.setCellRenderer(cellInfo -> DominoElement.div().appendChild(TextNode.of(cellInfo.getRecord().getCode())).element())
);
LocalListDataStore<City> localListDataStore = new LocalListDataStore<>();
DataTable<City> cityDataTable= new DataTable<>(tableConfig, localListDataStore);
layout.getContentPanel().appendChild(Card.create()
.appendChild(cityDataTable)
);
localListDataStore.setData(cities);
}
}It pretty fast even though in this example I had to loop the 5000 records twice unlike the javascript sample above. |
Beta Was this translation helpful? Give feedback.
-
|
Even tested with header filters and it is still fast 🤔 @FrankW76 Can you post a sample where this is slow for you. |
Beta Was this translation helpful? Give feedback.
-
|
In your example, how long does the : localListDataStore.setData(cities); take? For me that line is about 12 seconds. I could also take a look in the cellRenderers code as we do quite a lot of stuff in those. If something is chocking it up. |
Beta Was this translation helpful? Give feedback.
-
|
I managed to make it a lot faster with optimizing cellrenders. Like from 12 seconds to 2 or 3 seconds. One column that is giving me some issues is with boolean columns. If add this column it will directly add 4 or 5 seconds extra to the time to load. ` if (callback != null) return switchButton.element();` This take some time for each cell. |
Beta Was this translation helpful? Give feedback.
-
|
I use an approach for common column configs that does not require reflection by passing some sort of suppliers functions like this : first define a supplier function @FunctionalInterface
public interface BooleanSupplier<T> {
boolean getBoolean(T bean);
}then create a static factory method for the column config : public static <T> ColumnConfig<T> yesNo(BooleanSupplier<T> booleanSupplier, String name, String label) {
return ColumnConfig.<T>create(name, Labels.get(label))
.sortable()
.setCellRenderer(cellInfo ->
BooleanTableCell.trueFalseCell(booleanSupplier.getBoolean(cellInfo.getRecord())));
}then whenever I need a column that display tableConfig
...
.addColumn(CommonColumns.yesNo(BillerUIResource::getRefundAllowed, "name", "label"))
...And you can even make a factory class for those common column that delegate to the static factory method based on field type. You can either use static checks to find the field type or do a code generattion .. IMHO this is much better than using something like reflect which is even affect GWT optimization. |
Beta Was this translation helpful? Give feedback.
-
|
I also encountered a slow perfomance at the DataTable especially having many columns and rows and using a Select as a cell renderer. This leads to loading times for the table up to several minutes. I will try to provide an example for that |
Beta Was this translation helpful? Give feedback.
-
|
Have you tried to test with the latest HEAD-SNAPSHOT. sorry handling this from sickness bed I need few days to recover. |
Beta Was this translation helpful? Give feedback.
-
|
I will try it, thx for the hint. Take your time to rest and get well soon |
Beta Was this translation helpful? Give feedback.
-
A discussion aimed at the performance of datatable with large data collection especially while using the LocalListStore.
Beta Was this translation helpful? Give feedback.
All reactions