Move to erlandono #81
Conversation
schonfinkel
commented
Dec 4, 2024
•
schonfinkel
commented
- Closes Move to erlandono #80
schonfinkel
force-pushed
the
move-to-erlandono
branch
from
d91151a to
543fee0
Compare
schonfinkel
force-pushed
the
move-to-erlandono
branch
from
543fee0 to
46b9ef6
Compare
| %-type monad(_A) :: | ||
| % {{ok, any(), any()}, select} | | ||
| % {{ok, any()}, delete} | | ||
| % {{ok, any()}, insert} | | ||
| % {{ok, any(), any(), any()}, insert} | | ||
| % {{ok, any()}, update} | | ||
| % {{error, any()}, any()}. |
There was a problem hiding this comment.
Could you elaborate why this would only make sense if we export it? I would like to keep it in order to keep it consistent on how the original erlando does its monads.
There was a problem hiding this comment.
I need to know which functions use this otherwise it's never used by the functions inside the module (it never typed anything) or outside it.
If you want to use outside it, we can export the type btw.
There was a problem hiding this comment.
I don't follow why this needs to be used somewhere to be uncommented. My intention is to keep it in order to maintain the pattern created by erlando. In this sense, keeping it in form of a comment, although non-ideal, is ok.
There was a problem hiding this comment.
@EduardoLR10 then why not import monad.monad? the lib actually exports the type.
There was a problem hiding this comment.
I don't know, I actually haven't thought of that. Should we do that?
