Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How this provider reacts with secrets ? #34

Open
Jeoffreybauvin opened this issue Aug 29, 2023 · 3 comments
Open

How this provider reacts with secrets ? #34

Jeoffreybauvin opened this issue Aug 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Jeoffreybauvin
Copy link

Hi,

I'm trying to debug why my terraform apply is not idempotent :

  # airflow_connection.airflow_connection["np6_api_key_display"] will be updated in-place
  ~ resource "airflow_connection" "airflow_connection" {
      ~ extra         = jsonencode(
          ~ {
              ~ api_key = "***" -> "myapikey"
            }
        )
        id            = "np6_api_key_display"
        # (3 unchanged attributes hidden)
    }

I saw this : https://github.com/apache/airflow/blob/3b3650e87d093d57a97b8701834c568f67327ab4/airflow/utils/log/secrets_masker.py#L59

How this provider reacts with this kind of secret ?

@DrFaust92
Copy link
Owner

The provider does nothing explict about secrets. the above diff is a change made on the ariflow server side (this is how the code youve sent relates to it)

we can make a change to explictly supress diff for those keys. wdyt?

@Jeoffreybauvin
Copy link
Author

@DrFaust92 I think it's a good idea :).

@DrFaust92 DrFaust92 added the enhancement New feature or request label Nov 27, 2023
@PedroMartinSteenstrup
Copy link

@DrFaust92 if you maybe have a decent idea of the scope of the change (beyond that issue), I'd be happy to try to contribute here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants