Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong skill description while Rimatomics mod is active #38

Open
TheLonerD opened this issue Jan 5, 2023 · 3 comments
Open

Wrong skill description while Rimatomics mod is active #38

TheLonerD opened this issue Jan 5, 2023 · 3 comments

Comments

@TheLonerD
Copy link

TheLonerD commented Jan 5, 2023

Skill description is broken if Rimatomics mod is active.
This might happen because translation data have SkillLevel key defined. With no source code available it's hard to find where this key can be used.

Game version: 1.4.3580 rev1304
My mod list:

Mod list

<activeMods>
  <li>brrainz.harmony</li>
  <li>ludeon.rimworld</li>
  <li>ludeon.rimworld.royalty</li>
  <li>ludeon.rimworld.ideology</li>
  <li>ludeon.rimworld.biotech</li>
  <li>jaxe.rimhud</li>
  <li>dubwise.rimatomics</li>
</activeMods>

Screenshots:

With Rimatomics

image

Without Rimatomics

image

@Bluebottle39
Copy link

Hello, I have the same issue but without RimHUD. It looks like its the same popup as in the bio.

@Diakon5
Copy link

Diakon5 commented Jun 2, 2023

<SkillLevel>{0} Requires Level {1} {2}</SkillLevel>

This translation key must be accidentally overriding a vanilla one, no clue where it's used due to a lack of source code.

@Sindusk
Copy link

Sindusk commented Jun 2, 2023

<SkillLevel>{0} Requires Level {1} {2}</SkillLevel>

This translation key must be accidentally overriding a vanilla one, no clue where it's used due to a lack of source code.

This is correct and the SkillLevel key is not translated in any of the code that I could read from decompiling the assembly. This key can be removed.

@TheLonerD TheLonerD changed the title RimHUD labels are broken Wrong skill description while RimHUD and Rimatomics are enabled Jun 18, 2023
Xaephia added a commit to Xaephia/Rimatomics that referenced this issue Feb 15, 2024
@TheLonerD TheLonerD changed the title Wrong skill description while RimHUD and Rimatomics are enabled Wrong skill description while Rimatomics mod is active May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants