DYN-9879: Py Engine Change pops up erroneously (#16747)

Author: ivaylo-matov

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

@@ -1755,7 +1755,11 @@ private void DynamoViewModelRequestUserSaveWorkflow(object sender, WorkspaceSave
 
             // Show the one-time Python Engine Change notification for the workspace
             var ws = dynamoViewModel.Model.CurrentWorkspace;
-            if (!ws.HasShownPythonAutoMigrationNotification && ws.ShowPythonAutoMigrationNotifications)
+            var prefSettings = dynamoViewModel.Model.PreferenceSettings;
+
+            if (!ws.HasShownPythonAutoMigrationNotification
+                && ws.ShowPythonAutoMigrationNotifications
+                && prefSettings.ShowPythonAutoMigrationNotifications)
             {
                 var cancelFirstDialogBox = ShowPythonEngineChangeNoticeAndMarkIfProceed();
                 if (cancelFirstDialogBox)

src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs

@@ -343,6 +343,7 @@ private void OnCurrentWorkspaceCleared(IWorkspaceModel workspace)
             // Close the CPython toast notification when workspace is cleared/closed
             DynamoViewModel.ToastManager?.CloseRealTimeInfoWindow();
             lastWorkspaceGuid = Guid.Empty;
+            CurrentWorkspace.ShowPythonAutoMigrationNotifications = false;
         }
 
         private void OnWorkspaceRemoveStarted(IWorkspaceModel workspace)
@@ -515,7 +516,7 @@ private void MigrateCPythonNodesForWorkspace()
                     customCount,
                     LoadedParams.StartupParams.PathManager.BackupDirectory);
 
-                CurrentWorkspace.ShowPythonAutoMigrationNotifications = preferenceSettings.ShowPythonAutoMigrationNotifications;
+                CurrentWorkspace.ShowPythonAutoMigrationNotifications = true;
             }
         }