Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some numbers "break" Cyrillic converter #3

Open
ENDrain opened this issue Aug 21, 2022 · 0 comments
Open

Some numbers "break" Cyrillic converter #3

ENDrain opened this issue Aug 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ENDrain
Copy link
Owner

ENDrain commented Aug 21, 2022

By design, Cyrillic converter supports reading numbers with decorator irregularities - including missing "thousand" marks. (Whether this design is right is another question - #4.) The problem here is that certain irregularly written numbers can break current translation algorithm.

Concider this number:
раi҂ра҃i

Let's agree that all our numbers are properly written left-to right, only some decorators are missing. Now, current algorithm will not interpret this as 111,111,000 as it should. It will interpret this as 222,000. It will take the "thousand" mark from the first numeral group and index value (1) for the second numeral group. Both will yield a multiplier of 1,000. Hence, 111*1,000 + 111*1,000 = 222,000.

@ENDrain ENDrain added the enhancement New feature or request label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant