fix: added comment to explain resetting the global provider settings

james-ctc · james-ctc · commit d3be06f7c2ad · 2025-01-23T09:11:16.000Z
Signed-off-by: James Chapman &lt;james.chapman@pionix.de&gt;
diff --git a/lib/staging/tls/openssl_util.cpp b/lib/staging/tls/openssl_util.cpp
@@ -407,6 +407,7 @@ pkey_ptr load_private_key(const char* filename, const char* password) {
     OpenSSLProvider provider;
 
     if (custom_key) {
+        // set global provider to custom settings
         provider.set_global_mode(OpenSSLProvider::mode_t::custom_provider);
     } else {
         provider.set_global_mode(OpenSSLProvider::mode_t::default_provider);
@@ -425,6 +426,7 @@ pkey_ptr load_private_key(const char* filename, const char* password) {
     }
 
     if (custom_key) {
+        // reset global provider back to default settings
         provider.set_global_mode(OpenSSLProvider::mode_t::default_provider);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -407,6 +407,7 @@ pkey_ptr load_private_key(const char* filename, const char* password) {`
`407`	`407`	`OpenSSLProvider provider;`
`408`	`408`
`409`	`409`	`if (custom_key) {`
	`410`	`+ // set global provider to custom settings`
`410`	`411`	`provider.set_global_mode(OpenSSLProvider::mode_t::custom_provider);`
`411`	`412`	`} else {`
`412`	`413`	`provider.set_global_mode(OpenSSLProvider::mode_t::default_provider);`
`@@ -425,6 +426,7 @@ pkey_ptr load_private_key(const char* filename, const char* password) {`
`425`	`426`	`}`
`426`	`427`
`427`	`428`	`if (custom_key) {`
	`429`	`+ // reset global provider back to default settings`
`428`	`430`	`provider.set_global_mode(OpenSSLProvider::mode_t::default_provider);`
`429`	`431`	`}`
`430`	`432`