Skip to content

Update docs #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

Update docs #144

merged 2 commits into from
May 3, 2024

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented May 2, 2024

Adopted to the new constructor functionality. No longer any usage of:

  • from_pars
  • default

github-actions[bot]
github-actions bot requested changes May 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added [scope] documentation Documentation only changes (major.minor.patch-EXTENSION) chore Chore changes to the code labels May 2, 2024
@andped10 andped10 requested a review from damskii9992 May 2, 2024 12:05
damskii9992
damskii9992 reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@damskii9992 damskii9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see how all the .from_pars calls are removed by your new implementation. Makes the code a lot cleaner :)
Looks good, just a small comment about further replacing abbreviations with descriptive names

@andped10 andped10 requested a review from damskii9992 May 3, 2024 10:21
@andped10 andped10 merged commit b1504f1 into develop May 3, 2024
26 checks passed
@andped10 andped10 deleted the 143-update-docs-to-reflect-the-new-constructor-functionality branch May 3, 2024 11:34
@andped10 andped10 mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@damskii9992 damskii9992 damskii9992 approved these changes

Assignees
No one assigned
Labels
chore Chore changes to the code [scope] documentation Documentation only changes (major.minor.patch-EXTENSION)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andped10 @damskii9992