Adoption to new easyscience (fitting, parameter unique name #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rozyczko
approved these changes
Aug 23, 2024
| super().__init__(name, interface, *models, **kwargs) | ||
| self.interface = interface | ||
|
|
||
| # Needed by the as_dict functionality | ||
| self.populate_if_none = False |
There was a problem hiding this comment.
there's no description of this boolean. Why is it needed in as_dict?
There was a problem hiding this comment.
added code comment:
# Needed to ensure an empty list is created when saving and instatiating the object as_dict -> from_dict
# Else collisions might occur in global_object.map
| 'thickness': self.thickness, | ||
| 'discretisation_elements': self._discretisation_elements, | ||
| 'thickness': float(self.thickness), | ||
| 'discretisation_elements': int(self._discretisation_elements), |
There was a problem hiding this comment.
why are those explicit coversions needed?
There was a problem hiding this comment.
PR response
These are properties that else appears weird in the dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No intended changes to functionality only adoption to the new easyscience lib.
Main changes are
raw_value->valueuid->unique_nameas_dictandfrom_dictpopulate_if_noneto prevent the creation of internal variables when creating an object usingfrom_dictunique_namesare determined for internal variables.When testing:
dict_round_trip(as_dictandfrom_dict) testsas_dictandfrom_dicttests