From 534405a2e9b202cc819f0ed3d5d9a4c0276f316f Mon Sep 17 00:00:00 2001 From: VESSILLER Date: Thu, 6 Feb 2025 15:29:09 +0100 Subject: [PATCH 1/2] FIX max file size to download not needed for WebPortal --- .../webportal/controllers/document.controller.class.php | 9 --------- 1 file changed, 9 deletions(-) diff --git a/htdocs/webportal/controllers/document.controller.class.php b/htdocs/webportal/controllers/document.controller.class.php index fa8690343fff1..d54ec6c9675c1 100644 --- a/htdocs/webportal/controllers/document.controller.class.php +++ b/htdocs/webportal/controllers/document.controller.class.php @@ -213,15 +213,6 @@ public function init() exit; } - $fileSize = dol_filesize($fullpath_original_file); - $fileSizeMaxDefault = 20 * 1024; // 20 Mo by default - $fileSizeMax = getDolGlobalInt('MAIN_SECURITY_MAXFILESIZE_DOWNLOADED', $fileSizeMaxDefault); - if ($fileSize > $fileSizeMax) { - dol_syslog('ErrorFileSizeTooLarge: ' . $fileSize); - print 'ErrorFileSizeTooLarge: ' . $fileSize . ' (max ' . $fileSizeMax . ')'; - exit; - } - // Hooks $hookmanager->initHooks(array('document')); $parameters = array('ecmfile' => $ecmfile, 'modulepart' => $modulepart, 'original_file' => $original_file, From 9573af55542a5813067609a5a197bab833e0c758 Mon Sep 17 00:00:00 2001 From: VESSILLER Date: Thu, 6 Feb 2025 17:33:02 +0100 Subject: [PATCH 2/2] Fix #32964 - default value must be very high --- .../webportal/controllers/document.controller.class.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/htdocs/webportal/controllers/document.controller.class.php b/htdocs/webportal/controllers/document.controller.class.php index d54ec6c9675c1..74df6e335de90 100644 --- a/htdocs/webportal/controllers/document.controller.class.php +++ b/htdocs/webportal/controllers/document.controller.class.php @@ -213,6 +213,14 @@ public function init() exit; } + $fileSize = dol_filesize($fullpath_original_file); + $fileSizeMax = getDolGlobalInt('MAIN_SECURITY_MAXFILESIZE_DOWNLOADED'); + if ($fileSizeMax && $fileSize > $fileSizeMax) { + dol_syslog('ErrorFileSizeTooLarge: ' . $fileSize); + print 'ErrorFileSizeTooLarge: ' . $fileSize . ' (max ' . $fileSizeMax . ')'; + exit; + } + // Hooks $hookmanager->initHooks(array('document')); $parameters = array('ecmfile' => $ecmfile, 'modulepart' => $modulepart, 'original_file' => $original_file,