From 17352d68f4cc68d27bee9d6a5011ffe3dbb30772 Mon Sep 17 00:00:00 2001
From: Alessio Scaiola <alessio.scaiola@ebury.com>
Date: Tue, 27 Sep 2022 10:42:50 +0200
Subject: [PATCH] [ONL-6702] - migrate navigation component to vue3 (#1289)

* [ONL-6702] - ref - migrated component props

* [ONL-6702] - ref - removed script

* [ONL-6702] - ref - rm unecessary props attributes

* [ONL-6702] - updated unit tests

* 2.1.2
---
 package-lock.json                             |  4 +-
 package.json                                  |  2 +-
 .../ec-navigation/ec-navigation.spec.js       |  6 +--
 .../ec-navigation/ec-navigation.vue           | 41 ++++++++-----------
 4 files changed, 23 insertions(+), 30 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 359747d46..14a6a2137 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "@ebury/chameleon-components",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@ebury/chameleon-components",
-      "version": "2.1.1",
+      "version": "2.1.2",
       "license": "MIT",
       "dependencies": {
         "@vueuse/core": "9.2.0",
diff --git a/package.json b/package.json
index 3d972b544..a82d954fe 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ebury/chameleon-components",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "main": "src/main.js",
   "sideEffects": false,
   "author": "Ebury Team (http://labs.ebury.rocks/)",
diff --git a/src/components/ec-navigation/ec-navigation.spec.js b/src/components/ec-navigation/ec-navigation.spec.js
index 87e8f990f..df9aa6292 100644
--- a/src/components/ec-navigation/ec-navigation.spec.js
+++ b/src/components/ec-navigation/ec-navigation.spec.js
@@ -20,10 +20,8 @@ describe('EcNavigation', () => {
     withMockedConsole((errorSpy, warnSpy) => {
       mount(EcNavigation);
 
-      expect(warnSpy).toHaveBeenCalledTimes(3);
-      expect(warnSpy.mock.calls[0][0]).toContain('Missing required prop: "isCollapsed"');
-      expect(warnSpy.mock.calls[1][0]).toContain('Missing required prop: "isCollapsable"');
-      expect(warnSpy.mock.calls[2][0]).toContain('Missing required prop: "branding"');
+      expect(warnSpy).toHaveBeenCalledTimes(1);
+      expect(warnSpy.mock.calls[0][0]).toContain('Missing required prop: "isCollapsable"');
     });
   });
 
diff --git a/src/components/ec-navigation/ec-navigation.vue b/src/components/ec-navigation/ec-navigation.vue
index 35b6a8520..8efb8fe30 100644
--- a/src/components/ec-navigation/ec-navigation.vue
+++ b/src/components/ec-navigation/ec-navigation.vue
@@ -53,30 +53,25 @@
   </div>
 </template>
 
-<script>
-export default {
-  name: 'EcNavigation',
-  props: {
-    isCollapsed: {
-      type: Boolean,
-      required: true,
-      default: false,
-    },
-    isCollapsable: {
-      type: Boolean,
-      required: true,
-    },
-    branding: {
-      type: Object,
-      default: () => ({}),
-      required: true,
-    },
-    showBrandingLogo: {
-      type: Boolean,
-      default: true,
-    },
+<script setup>
+defineProps({
+  isCollapsed: {
+    type: Boolean,
+    default: false,
   },
-};
+  isCollapsable: {
+    type: Boolean,
+    required: true,
+  },
+  branding: {
+    type: Object,
+    default: () => ({}),
+  },
+  showBrandingLogo: {
+    type: Boolean,
+    default: true,
+  },
+});
 </script>
 
 <style>