Landing Page initial #8
Conversation
✅ Deploy Preview for currenci-ecell ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/model/Testimonial.ts
Outdated
| updatedAt: { | ||
| type: Date, | ||
| required: true, | ||
| default: () => moment().tz("Asia/Kolkata").toDate(), |
There was a problem hiding this comment.
never assign time at schema level. Assign time in a controller
src/app/(pages)/page.js
Outdated
| export default function Home() { | ||
| return ( | ||
| <main className="bg-white w-screen min-h-screen flex flex-col items-center pb-16"> | ||
| <div className="w-[80vw] h-[45vw] rounded-lg md:rounded-3xl mt-28"> |
There was a problem hiding this comment.
reduce height for wider displays. Its covering the more than screen height
| key={item.title} | ||
| > | ||
| <div | ||
| className={`w-[84vw] h-[35vw] md:h-[30vw] mx-[10vw] p-[4vw] rounded-3xl flex items-center justify-evenly text-justify ${index % 2 === 1 ? "flex-row-reverse" : ""}`} |
There was a problem hiding this comment.
don't use vw for height cause for larger wider displays it looks hideous.
There was a problem hiding this comment.
Refer to design and adhere to it. You components doesn't match with design
|
Can you spot any differene bw the 6vw and 3.5vw . To me the 3.5 one looks slightly larger. |
|
Don't use vw units for anything except the width otherwise you won't have control over how your component looks.
The margin ,padding looks way different than the design. Also if you are fixing the height of outer div then fix the height of inner div as well. The quote does not look good as it looks aligned downwards. |
|
In the preview, the heading might be of yellow but in design its of green so keep it like that. Thats a preview error, not your fault though. |
|
|
|
Do you see the ratio of padding to content. this what happens when you try to fit everything with vw. |
|
why did you put uneven margins in text div? It pushes it away from the centre. Also change the text size for different width.
this is the final change required guess, this button will direct to pricing page |
|
excessive padding and margin. Just imagine of fitting two of these in a single viewport(don't need to actually fit). |
| style={{ fontFamily: "Sofia Pro UltraLight" }} | ||
| > | ||
| {item.content} | ||
| {item.content.split(" ").slice(0, 80).join(" ")}... |
There was a problem hiding this comment.
will it not add '...' even if the content <80? Its better to condition on character rather than on words.(length of a word varies..) . Do the samething for anywhere with longer text.
No description provided.