Darkmode toggler #260
Merged
Darkmode toggler #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sristi2004-developer
requested review from
Ruler45,
dheeraj1922d,
r4inr3aper,
Z-Maniac-Sidd and
Ecell23
as code owners
|
@Sristi2004-developer is attempting to deploy a commit to the team ecell Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Dark mode doesn't persist after reload. FIX that |
|
still the same issue. Take help from your friends in E-cell |
dheeraj1922d
reviewed
Sep 4, 2024
src/context/ThemeContext.jsx
Outdated
| } else { | ||
| if (currentMode == "false") { | ||
| document.body.classList.remove("dark-theme"); | ||
| localStorage.setItem("isDarkMode", "false"); |
There was a problem hiding this comment.
Redundant Local Storage Update : updating local Storage multiple times within the render phase, which is unnecessary
There was a problem hiding this comment.
Use UseEffect to update the document.body class and localStorage whenever isDarkMode changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a ThemeContext.jsx file which provides a DarkMode state to track whether the Dark mode is enabled and a toggleTheme function to switch between light and dark modes and used this context into the navbar component using useContext hook.