Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

[DOCS] Spelling email #4887

Closed
janet-dev opened this issue Aug 6, 2022 · 20 comments
Closed

[DOCS] Spelling email #4887

janet-dev opened this issue Aug 6, 2022 · 20 comments
Labels
📄 aspect: text bug Something isn't working good first issue issue for people new to tech or the project 🔢 points: 1 🏁 status: ready for dev

Comments

@janet-dev
Copy link
Member

Description of the bug

Two different spellings - 'email' and 'e-mail' for the CODE_OF_CONDUCT.md.

https://github.com/EddieHubCommunity/support/blob/main/CODE_OF_CONDUCT.md

Just wondering if there is a site wide convention?

Project stack or language (e.g. front-end)

front-end

Working Environment (e.g. operating system, browser, device)

MacOS Catalina v10.15.5, Chrome, MacBook Pro

Please add screenshots (if applicable)

CODE_OF_CONDUCT

Add any other context about the problem here

Here is an interesting article "Is it e-mail, email, E-mail or Email?"

https://www.future-perfect.co.uk/grammar-tips/evolving-words/is-it-e-mail-email-e-mail-or-email

@janet-dev janet-dev added the bug Something isn't working label Aug 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@schmelto schmelto changed the title [BUG] <bug description> [DOCS] Spelling email Aug 19, 2023
@Madankh
Copy link

Madankh commented Aug 20, 2023

hey can i solve this

@kiranrega
Copy link

please assign this to me I will work on it

@janet-dev
Copy link
Member Author

Thank you @Saiteja-Basam for doing that.

@janet-dev
Copy link
Member Author

@Saiteja-Basam I am not an assigned reviewer. @kiranrega, if you are an official reviewer - can you review and merge for us?

@mathanraj0601
Copy link
Member

Is the issue still there can I contribute?

@vishesh-hue
Copy link

PPLLLLZZZ GIBBBB MEEEE THISSS ONEEEEE

@janet-dev
Copy link
Member Author

Thank you for your offers, but the change has been done. We are waiting for an authorised reviewer to approve and merge the PR. See the above comments 🤩

@Anjalisharma3463
Copy link
Contributor

#8228
hello @janet-dev ,
I've read that documentation that you have mentioned and i changed accordingly and also i mentioned the reason in PR why we want to change e-mail --> email.

I hope it will be merged.
Thank u!

@eddiejaoude
Copy link
Member

eddiejaoude commented Sep 25, 2023

Thank you for raising @janet-dev 👍

Thanks for raising @Anjalisharma3463 - I will review now.

Please note that this file is from a template, so I suggest someone proposing an update to the official repo

@realdezzy
Copy link

Maintainers should close this issue.

@zaid50015
Copy link

This issue is not open anymore?

@jovylle
Copy link
Member

jovylle commented Oct 11, 2023

I nominate this to be closed.

@drvcodenta
Copy link

Is this issue still open?

@MiirzaBaig
Copy link

Is it still opened or resovled?

@adityaraute
Copy link
Member

If the PR is merged, why didn't the Issue get closed automatically?

@oahmadgit
Copy link

I guess the linked PR still needs 1 more approval from the repo owners to get merged.

@Axxi3
Copy link

Axxi3 commented Jan 28, 2024

is it still open?

@Amitkumarkoli
Copy link

Is this issue still open?

@eddiejaoude
Copy link
Member

Thank you everyone, this was completed in this PR https://github.com/EddieHubCommunity/support/pull/8228/files and the issue should now be closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text bug Something isn't working good first issue issue for people new to tech or the project 🔢 points: 1 🏁 status: ready for dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.