Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docker file #6

Closed
anneferger opened this issue Sep 27, 2021 · 7 comments · Fixed by #7
Closed

Create Docker file #6

anneferger opened this issue Sep 27, 2021 · 7 comments · Fixed by #7
Assignees
Milestone

Comments

@anneferger
Copy link
Member

anneferger commented Sep 27, 2021

but there are some difficulties to download the artifacts from GitHub:

  • authentication (just as a registrated user with public_repo access and no other rights)
  • url of the most recent artifact cannot be easily created
@anneferger
Copy link
Member Author

See baz-ga/Edirom-Online#8

@anneferger
Copy link
Member Author

@anneferger
Copy link
Member Author

anneferger commented Sep 27, 2021

We will use https://nightly.link/ so that no authentication is needed for building the Docker image locally

peterstadler added a commit that referenced this issue Sep 27, 2021
remove builder stage and use nightly.link for downloading artifacts
@peterstadler
Copy link
Member

just added the nightly.link app, set up the artifact links and pushed the Dockerfile. Some questions now:

  1. the main REST endpoint of the MEIGarage is now /meigarage/. Do we want this—for historic and compatibility reasons— to be /ege-webservice/? Or do we now want this to be directly under root /?
  2. is LibreOffice needed for the MEIGarage? Getting rid of it would result in a much slimmer image.
  3. where is the log4j configuration? It's referred to at

    MEIGarage/Dockerfile

    Lines 52 to 53 in 2ddb1fe

    # where do we put/get this?
    # COPY log4j.xml /var/cache/oxgarage/log4j.xml
    but not in this repo. Is it save to copy it from https://github.com/TEIC/oxgarage/blob/dev/log4j.xml or is it in some other repo now?

@anneferger
Copy link
Member Author

  1. Yes good point, I'll keep it at /ege-webservice/ for now and if we decide to change it we can discuss that again
  2. I'll have a look if it is really not needed anywhere in MEIGarage
  3. There are two versions of those log configurations in the original repos, I added the respective ones to MEIGarage and TEIGarage

@anneferger
Copy link
Member Author

Should we also rename the artifacts to ege-webservice.war again? Could be helpful to have different names for different functions of the garages.

@anneferger
Copy link
Member Author

1a3f5d5

@anneferger anneferger added this to the 0.6.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants