Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing deletes score data #45

Closed
peterstadler opened this issue Dec 17, 2020 · 3 comments · Fixed by #64
Closed

Editing deletes score data #45

peterstadler opened this issue Dec 17, 2020 · 3 comments · Fixed by #64
Assignees
@peterstadler @AnastasiaWawilow
Labels
investigate Need further investigation
Milestone
Release 2.0

Comments

@peterstadler
Copy link
Member

this is a copy of kb-dk#190 and untested.
Yet we should make doubly sure that this issue is fixed or non-existent!
@peterstadler peterstadler added this to the Release 2.0 milestone Dec 17, 2020
@MauPalantir
Copy link
Collaborator

@peterstadler how to test this?

@peterstadler
Copy link
Member Author

grab some file with a music section (e.g. from https://github.com/music-encoding/sample-encodings), upload it to the MerMEId, alter it with the MerMEId and see whether the music section survives this process.

@peterstadler peterstadler self-assigned this Feb 15, 2021
@peterstadler peterstadler added the investigate Need further investigation label Feb 15, 2021
@AnastasiaWawilow
Copy link

We tested, the issue is not fixed.
We used Incipit Demo for the test. We have expanded the music tag in eXide. In MerMEID we have changed the title and saved it. We opened the file again in eXide, we noticed that the music tag is empty.

peterstadler added a commit that referenced this issue May 14, 2021
@peterstadler
set MEI file path as parameter #45
1db4e2b 
which is expected by the Stylesheet at `filter/xsl/filter_put.xsl`
peterstadler added a commit that referenced this issue May 14, 2021
@peterstadler
add mode='#all' to template, closes #45
8b9dfb6 
the default mode is rarely touched in this Stylesheet since the initial match template at https://github.com/Edirom/MerMEId/blob/de50ec700d7eead0514d22fe601979e2a0ce437f/filter/xsl/filter_put.xsl#L37 only applies templates recursively in the "convertEntities" mode.
NB: This might be an issue for several other templates (e.g. "m:expression") as well!
@peterstadler peterstadler mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterstadler peterstadler

@AnastasiaWawilow AnastasiaWawilow

Labels
investigate Need further investigation
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging a pull request may close this issue.

re-add the mei:music part on PUT Edirom/MerMEId
3 participants
@MauPalantir @peterstadler @AnastasiaWawilow