Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds camera_info yaml file #169

Closed
2 tasks
francocipollone opened this issue Oct 30, 2023 · 2 comments · Fixed by #231
Closed
2 tasks

Adds camera_info yaml file #169

francocipollone opened this issue Oct 30, 2023 · 2 comments · Fixed by #231
Labels
documentation Improvements or additions to documentation enhancement New feature or request software

Comments

@francocipollone
Copy link
Collaborator

francocipollone commented Oct 30, 2023

Summary

When launching the camera we are not passing a yaml with the description of the camera's intrinsics

def generate_launch_description():
return LaunchDescription([
Node(
package='v4l2_camera',
executable='v4l2_camera_node',
output='screen',
parameters=[{
'image_size': [640,480],
'camera_frame_id': 'camera_link'
}]
)
])

Notes

Definition of done

  • Adds a default yaml file descringin camera intrinsic.
  • Adds documentation about how to calibrate the camera if needed.
@francocipollone francocipollone added documentation Improvements or additions to documentation enhancement New feature or request software labels Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Andino Roadmap Oct 30, 2023
@JesusSilvaUtrera
Copy link
Contributor

I will take care of this issue

@JesusSilvaUtrera
Copy link
Contributor

I have created this PR @agalbachicar

jballoffet added a commit that referenced this issue Jun 17, 2024
* Improves andino_navigation package. (#224)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Add basic Platform IO instructions (#229)

Signed-off-by: Gary Servin <gary@servin.dev>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Modify Shell class API to allow dependency injection (#221)

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Fixed wheel diameter in URDF (#93)

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added YAML file for default camera intrinsics (#169)

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Adds references to o3de and isaac_sim simulations. (#232)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added README for andino_bringup (#233)

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added binaries installation docs (#234)

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* andino_apps package created and andino_navigation package updated (#235)

* andino_apps package created and andino_navigation package updated

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Minor changes from the PR

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Update andino_navigation README with changes from PR

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Add andino_apps package to ci.yaml

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Fixed minor issues from the PR

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added 'andino_apps' to the general README

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

---------

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Minimal change to test launch file

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added webcam.yaml file and intrinsics are now publishing

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

* Changed the 'camera_info_url' to be relative path

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>

---------

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: Gary Servin <gary@servin.dev>
Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com>
Co-authored-by: Gary Servin <gary@servin.dev>
Co-authored-by: Javier Balloffet <javier.balloffet@gmail.com>
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Andino Roadmap Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request software
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants