prevent height not divisible by 2

Author: QuentinGab

src/Definitions/MediaConversionPoster.php

@@ -8,6 +8,7 @@
 use Elegantly\Media\Enums\MediaType;
 use Elegantly\Media\Models\Media;
 use Elegantly\Media\Models\MediaConversion;
+use FFMpeg\Coordinate\TimeCode;
 use Illuminate\Contracts\Filesystem\Filesystem;
 use ProtoneMedia\LaravelFFMpeg\Support\FFMpeg;
 use Spatie\Image\Enums\Fit;
@@ -26,7 +27,7 @@ public function __construct(
         public ?string $queue = null,
         public array $conversions = [],
         public ?string $fileName = null,
-        public float $seconds = 0.0,
+        public TimeCode|float $seconds = 0.0,
         public ?int $width = null,
         public ?int $height = null,
         public Fit $fit = Fit::Contain,
@@ -69,7 +70,11 @@ public function handle(
 
         FFMpeg::fromFilesystem($filesystem)
             ->open($file)
-            ->getFrameFromSeconds($this->seconds)
+            ->getFrameFromTimecode(
+                is_float($this->seconds)
+                ? TimeCode::fromSeconds($this->seconds)
+                : $this->seconds
+            )
             ->export()
             ->save($fileName);
 

src/Definitions/MediaConversionVideo.php

@@ -73,14 +73,13 @@ public function handle(
 
         $ratio = new AspectRatio($source->aspect_ratio);
 
-        $width = $this->width;
-        $height = $this->height;
+        $modulus = match (true) {
+            $this->format instanceof X264 => 2, // dimensions must be divisible by 2
+            default => 1,
+        };
 
-        if ($width && ! $height) {
-            $height = $ratio->calculateHeight($width);
-        } elseif ($height && ! $width) {
-            $width = $ratio->calculateWidth($height);
-        }
+        $width = $this->width ?? ($this->height ? $ratio->calculateWidth($this->height, $modulus) : null);
+        $height = $this->height ?? ($this->width ? $ratio->calculateHeight($this->width, $modulus) : null);
 
         $ffmpeg = FFMpeg::fromFilesystem($filesystem)
             ->open($file)