Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a bunch of paragraph breaks. #215

Merged
merged 4 commits into from
Sep 23, 2024
Merged

docs: add a bunch of paragraph breaks. #215

merged 4 commits into from
Sep 23, 2024

Conversation

apoelstra
Copy link
Member

There is a new clippy/rustc nightly lint about having massive paragraphs as the first line of doccomments. The first line is treated specially and should be reasonably short.

There is a new clippy/rustc nightly lint about having massive paragraphs
as the first line of doccomments. The first line is treated specially
and should be reasonably short.
@apoelstra
Copy link
Member Author

Lol this fuzzer failure might be real.

We missed this when porting the rust-bitcoin decoding code to
rust-elements. But fortunately the fuzzer caught it very quickly.
@apoelstra
Copy link
Member Author

Ok, ready for review. This now includes an actual bugfix (and I ran the fuzzer locally for several minutes to double-check.)

Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3af727

Sorry I missed this for some time

@RCasatta RCasatta merged commit 0bd1328 into master Sep 23, 2024
5 checks passed
@apoelstra apoelstra deleted the 2024-08--docs branch September 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants