Fixed compile errors (again). (#310)

Signed-off-by: AraHaan <seandhunt_7@yahoo.com>

Author: AraHaan

ref/BlowFish/.editorconfig

@@ -149,3 +149,6 @@ dotnet_diagnostic.S3903.severity = none
 
 # S1133: Deprecated code should be removed
 dotnet_diagnostic.S1133.severity = suggestion
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

ref/Common/.editorconfig

@@ -149,3 +149,6 @@ dotnet_diagnostic.CA1307.severity = warning
 
 # S3903: Move '%s' into a named namespace.
 dotnet_diagnostic.S3903.severity = none
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

ref/GitInformation/.editorconfig

@@ -152,3 +152,6 @@ dotnet_diagnostic.S3903.severity = none
 
 # S1133: Do not forget to remove this deprecated code someday.
 dotnet_diagnostic.S1133.severity = none
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

ref/MiniDump/.editorconfig

@@ -152,3 +152,6 @@ dotnet_diagnostic.CA1303.severity = warning
 
 # S3903: Move '%s' into a named namespace.
 dotnet_diagnostic.S3903.severity = none
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

ref/PluginFramework/.editorconfig

@@ -149,3 +149,6 @@ dotnet_diagnostic.S101.severity = none
 
 # S3903: Move '%s' into a named namespace.
 dotnet_diagnostic.S3903.severity = none
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

ref/PluginUpdateCheck/.editorconfig

@@ -161,3 +161,6 @@ dotnet_diagnostic.S3903.severity = none
 
 # IDE0251: Make member 'readonly'
 dotnet_diagnostic.IDE0251.severity = silent
+
+# S2325: Methods and properties that don't access instance data should be static
+dotnet_diagnostic.S2325.severity = none

src/UnluacNET/.editorconfig

@@ -193,3 +193,6 @@ dotnet_diagnostic.IDE0072.severity = suggestion
 
 #Remove unnecessary usings/imports
 dotnet_diagnostic.IDE0005.severity = suggestion
+
+# S1244: Floating point numbers should not be tested for equality
+dotnet_diagnostic.S1244.severity = none

src/UnluacNET/Decompile/Decompiler.cs

@@ -1352,9 +1352,9 @@ private Assignment ProcessOperation(Operation operation, int line, int nextLine,
         // TODO: Optimize code
         if (stmt != null)
         {
-            if (stmt is Assignment)
+            if (stmt is Assignment _assign)
             {
-                assign = stmt as Assignment;
+                assign = _assign;
                 if (!assign.GetFirstValue().IsMultiple)
                 {
                     block.AddStatement(stmt);

src/UnluacNET/LuaDecompileStream.cs

@@ -33,6 +33,7 @@ public LuaDecompileStream(Stream input)
     /// <param name="keepOpen">
     /// Controls if the stream keeps the input stream open when the stream is disposed.
     /// </param>
+    [SuppressMessage("Style", "IDE0290:Use primary constructor", Justification = "Cannot be used for this class. This is a Roslyn Bug LOL.")]
     public LuaDecompileStream(Stream input, bool keepOpen)
     {
         this.BaseStream = input;

src/UnluacNET/Parse/LFunctionType.cs

@@ -33,7 +33,7 @@ public override LFunction Parse(Stream stream, BHeader header)
             s.VarArg);
     }
 
-    protected void ParseCode(Stream stream, BHeader header, LFunctionParseState s)
+    protected static void ParseCode(Stream stream, BHeader header, LFunctionParseState s)
     {
         if (header.Debug)
         {
@@ -54,7 +54,7 @@ protected void ParseCode(Stream stream, BHeader header, LFunctionParseState s)
         }
     }
 
-    protected void ParseConstants(Stream stream, BHeader header, LFunctionParseState s)
+    protected static void ParseConstants(Stream stream, BHeader header, LFunctionParseState s)
     {
         if (header.Debug)
         {
@@ -106,8 +106,8 @@ protected virtual void ParseMain(Stream stream, BHeader header, LFunctionParseSt
         s.LenParameter = stream.ReadByte();
         s.VarArg = stream.ReadByte();
         s.MaximumStackSize = stream.ReadByte();
-        this.ParseCode(stream, header, s);
-        this.ParseConstants(stream, header, s);
+        ParseCode(stream, header, s);
+        ParseConstants(stream, header, s);
         this.ParseUpvalues(stream, header, s);
         this.ParseDebug(stream, header, s);
     }

src/UnluacNET/Parse/LFunctionType52.cs

@@ -20,8 +20,8 @@ protected override void ParseMain(Stream stream, BHeader header, LFunctionParseS
         s.LenParameter = stream.ReadByte();
         s.VarArg = stream.ReadByte();
         s.MaximumStackSize = stream.ReadByte();
-        this.ParseCode(stream, header, s);
-        this.ParseConstants(stream, header, s);
+        ParseCode(stream, header, s);
+        ParseConstants(stream, header, s);
         this.ParseUpvalues(stream, header, s);
         this.ParseDebug(stream, header, s);
     }