Cleanup duplication of functions and defines

Author: Niam5

LuaEngine.h

@@ -392,11 +392,7 @@ class ELUNA_GAME_API Eluna
     void OnResurrect(Player* pPlayer);
     void OnQuestAbandon(Player* pPlayer, uint32 questId);
     void OnQuestStatusChanged(Player* pPlayer, uint32 questId, uint8 status);
-#if ELUNA_EXPANSION == RETAIL
-    void OnLearnTalents(Player* pPlayer, uint32 talentId, uint32 spellid);
-#else
     void OnLearnTalents(Player* pPlayer, uint32 talentId, uint32 talentRank, uint32 spellid);
-#endif
     void OnSkillChange(Player* pPlayer, uint32 skillId, uint32 skillValue);
     void OnLearnSpell(Player* pPlayer, uint32 spellid);
     InventoryResult OnCanUseItem(const Player* pPlayer, uint32 itemEntry);

hooks/PlayerHooks.cpp

@@ -26,16 +26,6 @@ using namespace Hooks;
     if (!PlayerEventBindings->HasBindingsFor(key))\
         return RETVAL;
 
-#if ELUNA_EXPANSION == RETAIL
-void Eluna::OnLearnTalents(Player* pPlayer, uint32 talentId, uint32 spellid)
-{
-    START_HOOK(PLAYER_EVENT_ON_LEARN_TALENTS);
-    HookPush(pPlayer);
-    HookPush(talentId);
-    HookPush(spellid);
-    CallAllFunctions(PlayerEventBindings, key);
-}
-#else
 void Eluna::OnLearnTalents(Player* pPlayer, uint32 talentId, uint32 talentRank, uint32 spellid)
 {
     START_HOOK(PLAYER_EVENT_ON_LEARN_TALENTS);
@@ -45,7 +35,6 @@ void Eluna::OnLearnTalents(Player* pPlayer, uint32 talentId, uint32 talentRank,
     HookPush(spellid);
     CallAllFunctions(PlayerEventBindings, key);
 }
-#endif
 
 void Eluna::OnSkillChange(Player* pPlayer, uint32 skillId, uint32 skillValue)
 {

methods/TrinityCore/GlobalMethods.h

@@ -79,13 +79,7 @@ namespace LuaGlobalFunctions
      */
     int GetCoreExpansion(Eluna* E)
     {
-#if ELUNA_EXPANSION == WOTLK
-        E->Push(2);
-#elif ELUNA_EXPANSION == CATA
-        E->Push(3);
-#elif ELUNA_EXPANSION == RETAIL
-        E->Push(9);
-#endif
+        E->Push(ELUNA_EXPANSION);
         return 1;
     }