Fix memory leak (#102)

noahsmartin · web-flow · commit 01e1b0f7b71a · 2024-10-22T09:33:43.000-04:00
diff --git a/ETTrace/Tracer/EMGStackTraceRecorder.cpp b/ETTrace/Tracer/EMGStackTraceRecorder.cpp
@@ -101,4 +101,7 @@ void EMGStackTraceRecorder::recordStackForAllThreads(bool recordAllThreads, thre
         size_t endIndex = addressStorage.size();
         emplaceResult.first->second.stacks.emplace_back(time, startIndex, endIndex);
     }
+    if (recordAllThreads) {
+      vm_deallocate(mach_task_self(), (vm_address_t) threads, sizeof(thread_t) * threadCount);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -101,4 +101,7 @@ void EMGStackTraceRecorder::recordStackForAllThreads(bool recordAllThreads, thre`
`101`	`101`	`size_t endIndex = addressStorage.size();`
`102`	`102`	`emplaceResult.first->second.stacks.emplace_back(time, startIndex, endIndex);`
`103`	`103`	`}`
	`104`	`+ if (recordAllThreads) {`
	`105`	`+ vm_deallocate(mach_task_self(), (vm_address_t) threads, sizeof(thread_t) * threadCount);`
	`106`	`+ }`
`104`	`107`	`}`