Add asan back as it appears that it was removed at some point

Author: EmilDohne

.github/workflows/cmake-test.yml

@@ -26,18 +26,26 @@ jobs:
              os: ubuntu-24.04
              compiler: gcc-13
              compilercxx: g++-13
+             cflags: ""
+             cxxflags: ""
            - name: Ubuntu Clang
              os: ubuntu-24.04
              compiler: clang
+             cflags: ""
+             cxxflags: ""
              compilercxx: clang++
            - name: Windows MSVC
              os: windows-latest
              compiler: msvc
              compilercxx: msvc
+             cflags: /fsanitize=address
+             cxxflags: /fsanitize=address
            - name: MacOS ARM GCC
              os: macos-latest
              compiler: gcc-13
              compilercxx: g++-13
+             cflags: ""
+             cxxflags: ""
 
     steps:
     - uses: actions/checkout@v4
@@ -63,6 +71,8 @@ jobs:
       env:
         CC: ${{ matrix.compiler }}
         CXX: ${{ matrix.compilercxx }}
+        CFLAGS: ${{ matrix.cflags }}
+        CXXFLAGS: ${{ matrix.cxxflags }}
       run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
 
     - name: Copy Testfiles on Windows

CMakeLists.txt

@@ -39,7 +39,7 @@ set(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake" ${CMAKE_MODULE_PATH})
 # Add libdeflate
 add_subdirectory (thirdparty/libdeflate)
 add_library(libdeflate_include INTERFACE)
-target_include_directories(libdeflate_include INTERFACE thirdparty/libdeflate)
+target_include_directories(libdeflate_include SYSTEM INTERFACE thirdparty/libdeflate)
 
 # Add mio for memory-mapped IO files
 add_subdirectory (thirdparty/mio)
@@ -55,12 +55,12 @@ add_subdirectory (thirdparty/c-blosc2 EXCLUDE_FROM_ALL)
 
 # Add target for blosc2 headers
 add_library(blosc2_include INTERFACE)
-target_include_directories(blosc2_include INTERFACE thirdparty/c-blosc2/include)
+target_include_directories(blosc2_include SYSTEM INTERFACE thirdparty/c-blosc2/include)
 
 
 # Add doctest
 add_library(doctest INTERFACE)
-target_include_directories(doctest INTERFACE thirdparty/doctest/doctest)
+target_include_directories(doctest SYSTEM INTERFACE thirdparty/doctest/doctest)
 
 # Add simdutf for UTF conversion operations
 set (SIMDUTF_TESTS OFF)
@@ -70,7 +70,7 @@ add_subdirectory (thirdparty/simdutf)
 
 # Add span from tcb for compatibility with older compilers for python bindings
 add_library(tcb_span INTERFACE)
-target_include_directories(tcb_span INTERFACE thirdparty/compatibility)
+target_include_directories(tcb_span SYSTEM INTERFACE thirdparty/compatibility)
 
 # Projects
 # --------------------------------------------------------------------------

PhotoshopAPI/CMakeLists.txt

@@ -16,11 +16,10 @@ if(MSVC)
 	target_compile_options(PhotoshopAPI PRIVATE /MP /DNOMINMAX)
 	target_compile_options(PhotoshopAPI PUBLIC /arch:AVX2 /Zc:__cplusplus /utf-8)
     # Bump up warning levels and enable the following extra exceptions:
-    # w44062 is for a switch misses some enum members.
-    # w44464 is for #include containing .. in the path (this should never happen)
+    # w44062 is for if a switch misses some enum members.
+    # w44464 is for #include containing .. in the path
     # w45264 is for using std:move when returning a temporary.
     target_compile_options(PhotoshopAPI PRIVATE /W4 /WX /w44062 /w44464 /w45264)
-    target_compile_options(PhotoshopAPI PRIVATE /wd4505 /wd4996) # Disable internal linkage and deprecation errors due to blosc2
 else()
     target_compile_options(PhotoshopAPI PUBLIC -O3)
     include(CheckCXXCompilerFlag)

PhotoshopTest/CMakeLists.txt

@@ -4,8 +4,14 @@ file(GLOB_RECURSE MY_SOURCES CONFIGURE_DEPENDS "src/*.cpp")
 enable_testing()
 
 add_executable(PhotoshopTest ${MY_SOURCES})
+
 if(MSVC)
+    # For MSVC we add the ASAN flags directly in the CI configuration as unfortunately MSVC requires
+    # this to be passed before any CMake even runs
     target_compile_options(PhotoshopTest PRIVATE /MP /utf-8)
+else()
+    add_compile_options(-fsanitize=address,leak,undefined)
+    add_link_options(-fsanitize=address,leak,undefined)
 endif()
 target_link_libraries(PhotoshopTest PRIVATE PhotoshopAPI doctest)
 

PhotoshopTest/src/main.cpp

@@ -23,6 +23,10 @@ int main()
 #endif
 	doctest::Context context;
 
+	// TMP trip asan
+	int x[100];
+	x[100] = 5;
+
 	// set defaults
 	context.setOption("abort-after", 5);	// stop test execution after 5 failed