Budgeting graph doesn't take real incomes

[EniXoo]

🐛 Bug Report

📋 Description

Hey there! I stumbled upon a bug while using this awesome project. Here's the scoop:

🔍 Steps to Reproduce

1. Create a fresh Bagels and an account
2. Check Manager > Budgeting > Remaining → It is 3500 by default
3. Go back on Home and add a new income, for example 3499

🤔 Expected Behavior

Remaining should change based on incomes.

😵 Actual Behavior

When the sum of income is stricly inferior too 3500 (which is the default) it doesn't change, but it does when the incomes exceeds it.

🛠️ Debugging Details

Version: 0.3.9
Environment: Windows 11 > Ubuntu (WSL)
Code Reference:

Bagels/src/bagels/managers/utils.py

Line 214 in a0c9b9a

def get_income_to_use(offset: int):

💡 Additional Context

At line 231, we are checking if limit ( if > 100 → current month incomes , last month incomes nor 0) is strictly inferior to fallback when we should check if it strictly inferior to threshold instead.

Thanks for checking this out! 🚀

[EnhancedJax]

This is expected, as it allows you to use the fallback when your actual income had not reached the expected income (fallback) yet. Though I don't understand why you said we should check if it strictly inferior to threshold instead.

[EniXoo]

I understand how fallback works 😉
You're talking about "expected income", is there a way to change it from Bagels? 👀

When I said we should check if it strictly inferior to threshold instead, I was thinking that treshold was acting as "minimum income" in order to switch to real income after it has been reached, but it make no sense if you tell me that you can change the fallback value 🫡

[EnhancedJax]

Bagels/src/bagels/config.py

Lines 73 to 82 in a0c9b9a

	# ---------- Income policies --------- #
	income_assess_metric: Literal["periodIncome", "fallback"] = (
	"periodIncome" # use the current period's income, or if less than threshold, use the past period's income
	)
	income_assess_threshold: float = (
	100 # if income less than this, we assume has no income
	)
	income_assess_fallback: float = (
	3500 # if income less than threshold, we use this as the income
	)

Sorry I might not have been clear. The way threshold and fallback works is, if the period's income is less than the threshold, the fallback is used. This allows a more flexible estimation of the month's expected and actual income.

EDIT: Inaccurate.

[EniXoo]

Ok, but this doesn't work as you've explain 😅

On my screen if income is below income_assess_fallback, it keeps using it instead of incomes 🤔

[EnhancedJax]

Actually thanks for pointing out the confusion of the matter. I've updated the documentation as followed. You were correct to point out that it didn't work as expected 😆

# periodIncome: use the current period's income, or if less than income_assess_threshold, use the past period's income. Uses income_assess_fallback if resulting income is less than it
# fallback: uses income_assess_fallback if income this period is less than it
income_assess_metric: Literal["periodIncome", "fallback"] = "periodIncome"
income_assess_threshold: float = 100
income_assess_fallback: float = 3500  # Minimum income

I'll close this issue if there are no more issues 👍🏻