Allocate buffer for each worker before handling query

Author: EnqueueDuck

README.md

@@ -12,7 +12,7 @@ To run the server, default host is 14396:
 bazel run -c opt src/main/cpp:server
 ```
 
-### Version 2.0
+### Version 2.1.0
 
 HTTP Server with N workers. Connections are distributed to the workers, each work handles IO
 using EPOLL.
@@ -22,12 +22,12 @@ user~/wrk (master) ./wrk -t8 -c 10000 -d20s http://host:14396
 Running 20s test @ http://host:14396
   8 threads and 10000 connections
   Thread Stats   Avg      Stdev     Max   +/- Stdev
-    Latency    51.63us  129.97us  48.81ms   99.68%
-    Req/Sec   103.74k    11.08k  134.55k    71.14%
-  2073920 requests in 20.10s, 79.11MB read
+    Latency    31.02us   37.16us  15.38ms   99.95%
+    Req/Sec    74.05k    26.72k  103.45k    59.33%
+  4420272 requests in 20.03s, 168.62MB read
   Socket errors: connect 8987, read 0, write 0, timeout 0
-Requests/sec: 103189.69
-Transfer/sec:      3.94MB
+Requests/sec: 220632.74
+Transfer/sec:      8.42MB
 ```
 
 ### Version 1.1

WORKSPACE

@@ -27,3 +27,13 @@ http_archive(
     patches = ["@//:third_party/bazel_patches/glog.patch"],
     patch_args = ["-p1"],
 )
+
+http_archive(
+    name = "third_party-event",
+    sha256 = "92e6de1be9ec176428fd2367677e61ceffc2ee1cb119035037a27d346b0403bb",
+    strip_prefix = "libevent-2.1.12-stable",
+    urls = [
+        "https://github.com/libevent/libevent/releases/download/release-2.1.12-stable/libevent-2.1.12-stable.tar.gz",
+    ],
+    build_file = "@//:third_party/bazel/BUILD.event",
+)

src/main/cpp/http/http_server.cpp

@@ -5,21 +5,22 @@
 namespace http {
 
 void HttpServer::Worker::HandleConnection(int connection_sd) {
-  char buffer[opts_.max_http_request_size];
-
   int bytes_read = 1;
   while (bytes_read) {
-    bytes_read = recv(connection_sd, buffer, sizeof(buffer), 0);
+    bytes_read = recv(connection_sd, buffer_.get(), opts_.max_http_request_size, 0);
     if (bytes_read < 0) {
-      LOG(ERROR) << "Error reading connection data";
+      // Connection reset by peer is normal
+      if (errno != ECONNRESET) {
+        LOG(ERROR) << "Error reading connection data " << errno;
+      }
       close(connection_sd);
       return;
     }
     if (bytes_read == 0) break;
 
     // Parse the http request
     request::HttpRequest request;
-    request.ParseFromString(buffer);
+    request.ParseFromString(buffer_.get());
 
     // Handle the request
     response::HttpResponse response = HandleRequest(request);
@@ -37,6 +38,7 @@ void HttpServer::Worker::Stop() {
 }
 
 void HttpServer::Worker::Initialize() {
+  buffer_ = std::make_unique<char[]>(opts_.max_http_request_size);
   epoll_fd_ = epoll_create1(0);
   thread_ = std::thread([this]() {
     struct epoll_event events[MAX_EPOLL_EVENTS];

src/main/cpp/http/http_server.h

@@ -18,7 +18,7 @@ struct HttpServerOpts {
 
 class HttpServer : public Server {
  public:
-  constexpr static int DEFAULT_HTTP_REQUEST_SIZE = 1024;
+  constexpr static int DEFAULT_HTTP_REQUEST_SIZE = 8192;
 
   explicit HttpServer(const HttpServerOpts &opts) : Server(opts.server_opts), opts_(opts) {
     for (int i = 0; i < opts_.num_workers; ++i) {
@@ -47,6 +47,7 @@ class HttpServer : public Server {
 
    private:
     WorkerOpts opts_;
+    std::unique_ptr<char[]> buffer_;
 
     int epoll_fd_;
     std::thread thread_;