Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - validateAtLeastOneDeviationFieldFilled #2437

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 17, 2024

Description

For this validation, I ended up not combining them into a single file as we had to split Deviation From Measure Specification section to two different components cause of the functionality change. So we have two validation files: validateAtLeastOneDeviationFieldFilled.ts & validateDeviationTextFieldFilled.ts

I would like to eventually rename the export component to validateDeviationTextFieldFilled in globalValidations/validateDeviationTextFieldFilled/index.ts but probably in a future pr as it will change the call for 2023 & 2024 measure files..

Related ticket(s)

CMDCT-3966


How to test

Deploy Link: https://dh5ps1l9eiznp.cloudfront.net/

  1. Sign into QMR, any state user
  2. Choose any reporting year
  3. Select any measure that has a measure specification
  4. In the Measure Specification section, select the first radio button. This will enable the Deviation From Measure Specification to show.
  5. Look below at the screenshots for what to fill, press validate and you should see the validation message below for the corresponding year.

For 2021 & 2022
Section
Screenshot 2024-09-17 at 1 17 13 PM

Validation
Screenshot 2024-09-17 at 1 17 21 PM


For 2023
Section
Screenshot 2024-09-17 at 1 02 50 PM
Validation
Screenshot 2024-09-17 at 1 02 59 PM


For 2024
Section
Screenshot 2024-09-17 at 1 03 07 PM
Validation
Screenshot 2024-09-17 at 1 03 13 PM

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Sep 17, 2024

Code Climate has analyzed commit 426a0fd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.6% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou marked this pull request as ready for review September 17, 2024 17:24
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Sep 17, 2024
@ajaitasaini ajaitasaini self-requested a review September 18, 2024 17:56
@ailZhou ailZhou merged commit d985a34 into master Sep 20, 2024
27 checks passed
@ailZhou ailZhou deleted the cmdct-3966-dev-field branch September 20, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants