GV Refactor - validateAtLeastOneDeviationFieldFilled #2437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For this validation, I ended up not combining them into a single file as we had to split Deviation From Measure Specification section to two different components cause of the functionality change. So we have two validation files: validateAtLeastOneDeviationFieldFilled.ts & validateDeviationTextFieldFilled.ts
I would like to eventually rename the export component to validateDeviationTextFieldFilled in
globalValidations/validateDeviationTextFieldFilled/index.ts
but probably in a future pr as it will change the call for 2023 & 2024 measure files..Related ticket(s)
CMDCT-3966
How to test
Deploy Link: https://dh5ps1l9eiznp.cloudfront.net/
For 2021 & 2022
Section
Validation
For 2023
Section
Validation
For 2024
Section
Validation
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod