Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When trying to upload one note all linked notes reuploaded #346

Closed
3 tasks done
anareaty opened this issue May 13, 2024 · 1 comment
Closed
3 tasks done

[Bug]: When trying to upload one note all linked notes reuploaded #346

anareaty opened this issue May 13, 2024 · 1 comment
Assignees
Labels
🐛 Bug Something isn't working

Comments

@anareaty
Copy link

Issue validation

  • I checked the issue to prevent duplicate
  • I checked my configurations files and the documentation
  • My issue concern doesn't concern the Mkdocs template

Command used

Upload single current active note

Plugin version

7.2.4

Describe the bug

When I try to upload one single note that have links to other published notes, all these notes are also upload, even if they are already uploaded and unchanged. If these notes have links to other notes, these other notes are also uploaded. With heavily linked notes this basically leads to always reuploading of all shared notes , which takes a lot of time.

How to reproduce ?

  1. Create notes "Test 1.md", "Test 2.md" and "Test 3.md", linked to each other, like in example below.
  2. Open note "Test 1.md" and run command "Upload single current active note".
  3. Try to run command again, withiut changing any notes. See that all three notes are reuploaded every time.

Minimal Reproducible Example

### Test 1.md

---
date: 2024-05-13
publishDate: 2024-05-13T10:07:00
path: content
filename: test-1
title: Test 1
share: true
---

Some text.

[[Test 2]]


### Test 2.md

---
date: 2024-05-13
publishDate: 2024-05-13T10:07:00
path: content
filename: test-2
title: Test 2
share: true
---

Some other text

[[Test 3]]


### Test 3.md

---
date: 2024-05-13
publishDate: 2024-05-13T10:07:00
path: content
filename: test-3
title: Test 3
share: true
---

Text text

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "dryRun": {
      "enable": false,
      "folderName": "github-publisher"
    },
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "yaml",
    "defaultName": "content",
    "rootFolder": "content",
    "yamlFolderKey": "path",
    "frontmatterTitle": {
      "enable": true,
      "key": "filename"
    },
    "replaceTitle": [],
    "replacePath": [],
    "autoclean": {
      "includeAttachments": false,
      "enable": true,
      "excluded": [
        "images/"
      ]
    },
    "folderNote": {
      "enable": false,
      "rename": "_index.md",
      "addTitle": {
        "enable": false,
        "key": "title"
      }
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": true,
      "wiki": false,
      "slugify": true
    }
  },
  "embed": {
    "attachments": true,
    "overrideAttachments": [],
    "keySendFile": [],
    "notes": true,
    "folder": "content/images",
    "convertEmbedToLinks": "bake",
    "charConvert": "->",
    "unHandledObsidianExt": [],
    "sendSimpleLinks": true,
    "forcePushAttachments": [],
    "bake": {
      "textBefore": "",
      "textAfter": ""
    }
  },
  "plugin": {
    "shareKey": "share",
    "excludedFolder": [],
    "copyLink": {
      "enable": false,
      "links": "",
      "removePart": [],
      "transform": {
        "toUri": true,
        "slugify": "lower",
        "applyRegex": []
      }
    },
    "setFrontmatterKey": "Set"
  }
}

Relevant log output

No response

OS

Android

Anything else?

No response

Obsidian information

SYSTEM INFO:
	Operating system: android 14 (Xiaomi 23030RAC7Y)
	Obsidian version: 1.5.12 (134)
	API version: v1.5.12
	Login status: not logged in
	Live preview: on
	Base theme: light
	Community theme: Sample Theme v1.0.0
	Snippets enabled: 22
	Restricted mode: off
	Plugins installed: 13
	Plugins enabled: 12
		1: Better Search Views v0.2.2
		2: Plugin Groups v2.1.0
		3: List Callouts v1.2.7
		4: Github Publisher v7.2.4
		5: Templater v2.3.1
		6: Dataview v0.5.66
		7: Modal forms v1.41.0
		8: QuickAdd v1.8.1
		9: Folder notes v1.7.22
		10: Front Matter Title v3.9.0
		11: Commander v0.5.1
		12: Note Toolbar v1.7.23

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
@anareaty anareaty added the 🐛 Bug Something isn't working label May 13, 2024
@Mara-Li
Copy link
Member

Mara-Li commented May 13, 2024

It's not a bug!
You can disable the new settings about sharing links (embed tab) to disable this behavior :).

@Mara-Li Mara-Li closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants