New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup good naming conventions for the refactor #1

Open

AdrienLeGuillou opened this issue Apr 6, 2023 · 0 comments

Assignees

Milestone

Member

AdrienLeGuillou commented Apr 6, 2023

Initial names lack consistency.

parameters / params: input given to the model, what we want to calibrate
proposal: a set of parameters to feed to the model
outcomes: outputs of the model. Values we use for checking the parameters
targets: the values of the outcomes we try to reach
model: a function that takes in proposals and spits out outcomes

default_proposal -> default_parameters
waves? jobs?

make_next_proposal -> proposer?
get_results -> tester? checker?

Once that is defined, cleanup code and check

AdrienLeGuillou self-assigned this

AdrienLeGuillou added this to the 0.1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment