Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse feature; getting columns from source; fix field name and table path #138

Closed
gladkikhtutu opened this issue Apr 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gladkikhtutu
Copy link

gladkikhtutu commented Apr 27, 2023

Hi! We used your package in our company for unit testing in DBT and we had some issues.

  1. Getting column names from query sometimes not work in our case, so we can need to get it from source.yaml table description. I added union of those ways.
  2. For clickhouse join is not working so we need to point out join algorithm and I added it under the conditional with adapter type. I guess it is not best practice to add such cases in code, and if you don't agree with such change, can you offer something better?
  3. In different databases you have only schema and no database name in table path, so node.database can be empty and I handle this case.
  4. Count is popular word and it can be a field in initial query, so we need to use more specific name

PR for these issues:
#137

@cdiniz cdiniz added the enhancement New feature or request label May 15, 2023
@cdiniz
Copy link
Collaborator

cdiniz commented Apr 15, 2024

Hi there, we are doing a clean-up of old/inactive Issues.
Happy to open again if there is a need for that.
Thank you for collaboration!

@cdiniz cdiniz closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants