Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to use dark mode, but didn't find a way to switch to dark theme #16

Open
eauchat opened this issue Jan 15, 2025 · 4 comments

Comments

@eauchat
Copy link

eauchat commented Jan 15, 2025

Thanks for the nice app, I'm using Janice on ubuntu, I would like to use it in dark mode but somehow I didn't find a way to do so.
It says it automatically sets the theme. But somehow it doesn't seem to work for me.

Could you add a menu to be able to manually set the theme from within the app?

Also at the moment, how does it choses which theme to use? What way could there be to change it (my gtk is already set to use a dark theme)?

Thanks for considering this issue :)

@ErikKalkoken
Copy link
Owner

Hey!

Janice should automatically use the current theme (light or dark) set for your desktop environment. I am also on Ubuntu 22.04 with Gnome and I just tested it again and it works on my system with the latest app image.

Which Janice version are you on? (app image or custom build?)
What Ubuntu and DE version exactly?

@eauchat
Copy link
Author

eauchat commented Jan 16, 2025

Hey, thanks for your answer.

I'm using what I think should be the latest app image: Janice-0.6.3-x86_64.AppImage.
Running this on Ubuntu 22.04 with i3wm.
Usually I can set gtk themes for apps through gtk-chtheme or lxappearance. Both of which are set to a dark theme.

Themes in apps are often a mess somehow, depending on the desktop environment, that's why I though a little setting allowing to customize the theme from inside the app could be nice.

@ErikKalkoken
Copy link
Owner

Thanks for the additional information.

Janice does not use gtk, it is build with the Fyne GUI toolkit, which use open GL to render the widgets. The theme is set by the current OS setting and can even be changed on-the-fly.

Just to be clear I understand the issue correctly: Is your OS set to dark mode, but the app is still showing in light mode? That would be a bug and I am happy to follow up on this with the Fyne developers.

Or are you asking to add a feature for setting the a theme independent from the current OS theme?

@eauchat
Copy link
Author

eauchat commented Jan 16, 2025

Thanks for your answer :)

Just to be clear I understand the issue correctly: Is your OS set to dark mode, but the app is still showing in light mode? That would be a bug and I am happy to follow up on this with the Fyne developers.

Well what's sure is that I'd like to have dark mode in Janice, but it seems to think my system is set to light mode.
How can I know what my OS is set to? I mean what kind of settings from the OS is Fyne watching? How can I query it and modify it? Because various apps seem to look in a different place for those settings. On my system I have gtk apps using a common dark theme, and kde ones using another dark theme, so already those get their info from different places.

Or are you asking to add a feature for setting the a theme independent from the current OS theme?

Well I guess maybe I'm asking for both ;-)
Now I'd like to understand what theme setting the app is getting from the system and how to modify it.
But if there was the possibility to change the theme in the app, I wouldn't have bothered you and just would have changed it from there. In my opinion it's a good feature to have, so the app can be independent from the OS which is useful in some situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants