libraries essential fix (#66)

* libraries essential fix

* libraries essential fix

Co-authored-by: Mateusz Wojczal <mateuszwojczal@Mateuszs-MacBook-Pro.local>

Author: qunabu

src/Http/Controllers/LibraryApiController.php

@@ -47,7 +47,7 @@ public function libraries(LibraryListRequest $request): JsonResponse
             $request->get('minorVersion')
         );
 
-        return $this->sendResponseForResource(LibraryResource::collection($libraries));
+        return response()->json($libraries, 200);
     }
 
     public function destroy(LibraryDeleteRequest $request, int $id): JsonResponse

src/Http/Requests/LibraryListRequest.php

@@ -10,7 +10,7 @@ class LibraryListRequest extends FormRequest
 {
     public function authorize(): bool
     {
-        return Gate::allows('list', H5PLibrary::class);
+        return true;
     }
 
     public function rules(): array

src/routes.php

@@ -34,3 +34,8 @@
         })->name('hh5p.index'); // DO not remove this is needed as prefix for editor ajax calls
     });
 });
+
+Route::group(['prefix' => 'api/hh5p'], function () {
+    Route::get('libraries', [LibraryApiController::class, 'libraries'])->name('hh5p.library.libraries');
+    Route::post('libraries', [LibraryApiController::class, 'libraries'])->name('hh5p.library.libraries');
+});

tests/Api/LibraryApiTest.php

@@ -12,7 +12,7 @@ public function test_library_uploading(): void
     {
         $this->authenticateAsAdmin();
         $filename = 'arithmetic-quiz.h5p';
-        $filepath = realpath(__DIR__.'/../mocks/'.$filename);
+        $filepath = realpath(__DIR__ . '/../mocks/' . $filename);
         $storage_path = storage_path($filename);
 
         copy($filepath, $storage_path);
@@ -68,17 +68,17 @@ public function testGuestCannotDeleteLibrary(): void
         $response->assertForbidden();
     }
 
-    public function testGuestCannotIndexLibrary(): void
+    public function testGuestCanIndexLibrary(): void
     {
         $response = $this->get('/api/admin/hh5p/library');
 
-        $response->assertForbidden();
+        $response->assertOk();
     }
 
     public function testGuestCannotUploadLibrary(): void
     {
         $filename = 'arithmetic-quiz.h5p';
-        $filepath = realpath(__DIR__.'/../mocks/'.$filename);
+        $filepath = realpath(__DIR__ . '/../mocks/' . $filename);
         $storage_path = storage_path($filename);
 
         copy($filepath, $storage_path);