Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopupViewer: Allow overriding URL clicks #576

Closed
dotMorten opened this issue Jun 6, 2024 · 1 comment · Fixed by #584 or #588
Closed

PopupViewer: Allow overriding URL clicks #576

dotMorten opened this issue Jun 6, 2024 · 1 comment · Fixed by #584 or #588
Assignees
Labels
Milestone

Comments

@dotMorten
Copy link
Member

dotMorten commented Jun 6, 2024

Currently if you click a link in the popup viewer it'll open the default browser. In some cases you might want to just open the link in a webview inside the app.
We should provide a similar approach as with attachment clicks, allowing users to cancel the default operation and perform their own.

Follow-up to issue #555 suggested by @bsundsbo

@prathameshnarkhede
Copy link
Contributor

This feature will be available in v200.5

dotMorten added a commit that referenced this issue Jul 26, 2024
@dotMorten dotMorten linked a pull request Aug 1, 2024 that will close this issue
dotMorten added a commit that referenced this issue Aug 1, 2024
* Set up v.next branch

* WPF/MAUI: FeatureForm attachments support (#581)

* Added missing trimming attribute

* Move code for getting parent to common location

* Add null-check

* Improve app theming and theme testing

* Adds support for the barcode input field (#583)

* Adds support for the barcode input field

* Added support to override URL clicks in PopupViewer (#584)

* Added support to override URL clicks in PopupViewer

* Added samples for reference

* Refactor PopupViewer and event handling

* Refactor hyperlink event handling and cleanup

- Corrected the event name from `HyperLinkClicked` to `HyperlinkClicked` in both XAML and code-behind files for consistency and to meet case sensitivity requirements.

* Refactor GetPopupViewerParent to generic

* Refactor GetParent<T> generic constraint

* Broaden type check in Tapped event handler

* Refine type checks and adjust imports

* Refactor PopupViewer parent traversal logic

* Add discard method to featureform that ensures the form is fully reset by re-evaluating expressions

All add Finish method for consistency

* Improve discards and avoiding cascading evaluations

* Add barcode scanner example to maui sample using ZXing

* Refetch attachment on discard

* Fix null warning

* Add error border below text field (#585)

Ensures on catalyst that the textfield isn't blocked form clicking when there's an error

* BugFix: BasemapGallery fails to load default Basemaps in WPF (#586)

* Optimize BasemapGallery initialization

Removed redundant initialization of `AvailableBasemaps` in the `BasemapGallery` constructor. Added a null check in `BasemapGallery_Loaded` to initialize `AvailableBasemaps` only if it is null, calling `_controller.LoadFromDefaultPortal()` asynchronously if needed. This change prevents unnecessary initialization and allows for external setting of `AvailableBasemaps` before the control is loaded.

* Initialize AvailableBasemaps and improve load check

Add initialization flag for BasemapGallery collection

* Raise hyperlink event for field links

#576

---------

Co-authored-by: Morten Nielsen <mort5161@esri.com>
Co-authored-by: Prathamesh Narkhede <55591622+prathameshnarkhede@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants