From e32b1e3255f0d91c1cdc630a78e1c85979a2f2f4 Mon Sep 17 00:00:00 2001 From: William Bohrmann Date: Mon, 3 Jun 2024 13:25:00 -0700 Subject: [PATCH 1/3] deprecate and replace --- .../FloorFilter/FloorFilter.cs | 29 +++++++++++++++++-- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs index 7c5a6589b..d379ed35a 100644 --- a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs +++ b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs @@ -341,7 +341,7 @@ private void HandleControllerPropertyChanges(object? sender, PropertyChangedEven _autoVisibilityWrapper?.SetValue(VisibilityProperty, _controller.ShouldDisplayFloorPicker ? Visibility.Visible : Visibility.Collapsed); break; case nameof(_controller.AllDisplayLevelsSelected): - OnPropertyChanged(nameof(AllDisplayLevelsSelecteded)); + OnPropertyChanged(nameof(AllDisplayLevelsSelected)); break; } } @@ -658,6 +658,7 @@ public void SetSelectedLevelWithoutZoom(FloorLevel newLevel) /// /// This is used for showing an entire facility in 3D. /// + [Obsolete("This property is deprecated. Use AllDisplayLevelsSelected instead.")] public bool AllDisplayLevelsSelecteded { get => _controller.AllDisplayLevelsSelected; @@ -673,9 +674,31 @@ public bool AllDisplayLevelsSelecteded } } } -#endregion Selection -#region Read-only list properties + /// + /// Gets or sets a value indicating whether all of the levels for the selected facility should be enabled for display. + /// + /// + /// This is used for showing an entire facility in 3D. + /// + public bool AllDisplayLevelsSelected + { + get => _controller.AllDisplayLevelsSelected; + set + { + if (value) + { + _controller.SelectAllDisplayLevels(); + } + else + { + _controller.UndoSelectAllDisplayLevels(); + } + } + } + #endregion Selection + + #region Read-only list properties #if WINDOWS_XAML From af4c598f2fe47b86a31a33f245159ba7cfdffa8e Mon Sep 17 00:00:00 2001 From: William Bohrmann Date: Mon, 3 Jun 2024 14:53:21 -0700 Subject: [PATCH 2/3] reviewer feedback --- .../FloorFilter/FloorFilter.cs | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs index d379ed35a..39053bb84 100644 --- a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs +++ b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs @@ -341,6 +341,7 @@ private void HandleControllerPropertyChanges(object? sender, PropertyChangedEven _autoVisibilityWrapper?.SetValue(VisibilityProperty, _controller.ShouldDisplayFloorPicker ? Visibility.Visible : Visibility.Collapsed); break; case nameof(_controller.AllDisplayLevelsSelected): + OnPropertyChanged(nameof(AllDisplayLevelsSelecteded)); OnPropertyChanged(nameof(AllDisplayLevelsSelected)); break; } @@ -661,18 +662,8 @@ public void SetSelectedLevelWithoutZoom(FloorLevel newLevel) [Obsolete("This property is deprecated. Use AllDisplayLevelsSelected instead.")] public bool AllDisplayLevelsSelecteded { - get => _controller.AllDisplayLevelsSelected; - set - { - if (value) - { - _controller.SelectAllDisplayLevels(); - } - else - { - _controller.UndoSelectAllDisplayLevels(); - } - } + get => AllDisplayLevelsSelected; + set => AllDisplayLevelsSelected = value; } /// From f9342b01c48f754140172783deb0269648a04bd0 Mon Sep 17 00:00:00 2001 From: William Bohrmann Date: Mon, 3 Jun 2024 15:57:59 -0700 Subject: [PATCH 3/3] hide from intellisense --- src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs index 39053bb84..54922a1f6 100644 --- a/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs +++ b/src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs @@ -659,6 +659,7 @@ public void SetSelectedLevelWithoutZoom(FloorLevel newLevel) /// /// This is used for showing an entire facility in 3D. /// + [EditorBrowsable(EditorBrowsableState.Never)] [Obsolete("This property is deprecated. Use AllDisplayLevelsSelected instead.")] public bool AllDisplayLevelsSelecteded {