Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Enhance component's interactive states #10003

Closed
7 of 11 tasks
geospatialem opened this issue Aug 8, 2024 · 3 comments
Closed
7 of 11 tasks

[Tabs] Enhance component's interactive states #10003

geospatialem opened this issue Aug 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2025-02-25 - Feb ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 8, 2024 •
edited
Loading

Check existing issues

Description

Updates the tabs interactive states as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

  • Increase :active state bottom border to 4px on :focus
  • For bordered="false": On the inactive tab-title, change text.3 to text.1 on :hover and :press
  • For bordered="true":
    • On active tab-title, remove :hover and :press states
    • On inactive tab-title, change text.3 to text.1 on :hover and :press

image

Relevant Info

Figma file

Which Component

tabs

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 2 Small fix or update, may require updates to tests. ready for dev Issues ready for development implementation. labels Aug 8, 2024
@geospatialem geospatialem mentioned this issue Aug 8, 2024
Open
27 tasks
@github-actions github-actions bot added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. Calcite (design) Issues logged by Calcite designers. labels Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 8, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Aug 8, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@aPreciado88 aPreciado88 self-assigned this Feb 7, 2025
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 7, 2025
@aPreciado88 aPreciado88 mentioned this issue Feb 7, 2025
Merged
aPreciado88 added a commit that referenced this issue Feb 10, 2025
@aPreciado88
feat(tab-title): enhance component's interactivity states (#11493)
f9d27fa 
**Related Issue:**
[#10003](#10003)

## Summary

- Increase `bottom-border` to `4px` on `focus` when `selected=true`.
- Change `text-color-3` to `text-color-1` on `hover` and `active` when
`bordered=false` and `selected=false`.
- When `bordered=true`:
    - Remove `hover` and `active` states when `selected=true`.
- Change `text-color-3` to `text-color-1` on `hover` and `active` when
`selected=false`.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 10, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Feb 12, 2025
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Feb 12, 2025
@geospatialem
Copy link
Member Author

Verified across all states in 3.1.0-next.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88