From ff645e2c33e51dd598bab6c3eee0b3511f54f021 Mon Sep 17 00:00:00 2001 From: Vishwas Kumar Date: Sat, 21 Feb 2026 11:39:49 +0530 Subject: [PATCH] Fixed unreachable nickNoMore Message in /nick command. Not a huge change. The display name was comparing getDisplayName() to itself, making it always true which made the nickNoMore message unreachable. Now it uses FormatUtil.stripFormat() to strip color codes before comparing against getName(), also has a null-safety guard. --- .../java/com/earth2me/essentials/commands/Commandnick.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Essentials/src/main/java/com/earth2me/essentials/commands/Commandnick.java b/Essentials/src/main/java/com/earth2me/essentials/commands/Commandnick.java index 9716816e126..a2c3f364ded 100644 --- a/Essentials/src/main/java/com/earth2me/essentials/commands/Commandnick.java +++ b/Essentials/src/main/java/com/earth2me/essentials/commands/Commandnick.java @@ -48,7 +48,8 @@ protected void updatePlayer(final Server server, final CommandSource sender, fin target.sendTl("nickNoMore"); } else if (target.getName().equalsIgnoreCase(nick)) { setNickname(server, sender, target, nick); - if (!target.getDisplayName().equalsIgnoreCase(target.getDisplayName())) { + final String strippedDisplay = FormatUtil.stripFormat(target.getDisplayName()); + if (strippedDisplay != null && !strippedDisplay.equalsIgnoreCase(target.getName())) { target.sendTl("nickNoMore"); } target.sendTl("nickSet", ess.getSettings().changeDisplayName() ? target.getDisplayName() : nick);