[WIP] Improve presentation of connection status #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or connections New status 'CLOSING' used while channel is being closed and set status CONNECTED once the connection has been established.
artur-ios-dev
changed the title
|
Thanks for working on this @artrmz - I was just running into the same problem and was almost at the point of making some changes on here and potentially websocket, so nice to see you did that already. |
|
@Jaribeau You are welcome! I am glad someone found it useful as well. Hoepfully dart-lang/web_socket_channel#85 will be merged soon so can finish it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New status 'CLOSING' used while the channel is being closed and set status CONNECTED once the connection has been established.
Also, this PR adds a possibility to set a timeout for the connection.
Closes #3
CAUTION: I have marked is as WIP since it requires dart-lang/web_socket_channel#85 to be merged. Not sure if it ever happens (web_socket_channel kinda seems to be abandoned) so changed a dependency to point on my forked repo and branch with the fix.
Btw. Maybe it will be better to add a status
TIMEOUTfor some cases? Anyway, it's something to consider on another PR.