Skip to content

Commit 6299a22

Browse files
Swift 5 migration and bump to 3.2 (#33)
1 parent 08fa8a2 commit 6299a22

35 files changed

+472
-174
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# Change Log
22
All notable changes to GooglePlacesRow will be documented in this file.
33

4+
### [3.2.0](https://github.com/EurekaCommunity/GooglePlacesRow/releases/tag/3.2.0)
5+
<!-- Released on 2018-10-08. -->
6+
7+
* Swift 5 migration
8+
* Upgrade to GooglePlaces 3.3
9+
410
### [3.1.0](https://github.com/EurekaCommunity/GooglePlacesRow/releases/tag/3.1.0)
511
<!-- Released on 2018-10-08. -->
612

Cartfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "xmartlabs/Eureka" ~> 4.3
1+
github "xmartlabs/Eureka" ~> 5.0

Cartfile.resolved

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "xmartlabs/Eureka" "4.0.1"
1+
github "xmartlabs/Eureka" "5.0.0"

Eureka

Submodule Eureka updated 69 files

Example.xcodeproj/project.pbxproj

+11-9
Original file line numberDiff line numberDiff line change
@@ -174,17 +174,17 @@
174174
isa = PBXProject;
175175
attributes = {
176176
LastSwiftUpdateCheck = 0720;
177-
LastUpgradeCheck = 1000;
177+
LastUpgradeCheck = 1020;
178178
TargetAttributes = {
179179
28F828CB1C4B714D00330CF4 = {
180180
CreatedOnToolsVersion = 7.2;
181-
LastSwiftMigration = 0920;
181+
LastSwiftMigration = 1020;
182182
};
183183
};
184184
};
185185
buildConfigurationList = 28F828C71C4B714D00330CF4 /* Build configuration list for PBXProject "Example" */;
186186
compatibilityVersion = "Xcode 3.2";
187-
developmentRegion = English;
187+
developmentRegion = en;
188188
hasScannedForEncodings = 0;
189189
knownRegions = (
190190
en,
@@ -301,6 +301,7 @@
301301
isa = XCBuildConfiguration;
302302
buildSettings = {
303303
ALWAYS_SEARCH_USER_PATHS = NO;
304+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
304305
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
305306
CLANG_CXX_LIBRARY = "libc++";
306307
CLANG_ENABLE_MODULES = YES;
@@ -343,7 +344,7 @@
343344
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
344345
GCC_WARN_UNUSED_FUNCTION = YES;
345346
GCC_WARN_UNUSED_VARIABLE = YES;
346-
IPHONEOS_DEPLOYMENT_TARGET = 9.2;
347+
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
347348
MTL_ENABLE_DEBUG_INFO = YES;
348349
ONLY_ACTIVE_ARCH = YES;
349350
SDKROOT = iphoneos;
@@ -355,6 +356,7 @@
355356
isa = XCBuildConfiguration;
356357
buildSettings = {
357358
ALWAYS_SEARCH_USER_PATHS = NO;
359+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
358360
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
359361
CLANG_CXX_LIBRARY = "libc++";
360362
CLANG_ENABLE_MODULES = YES;
@@ -391,7 +393,7 @@
391393
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
392394
GCC_WARN_UNUSED_FUNCTION = YES;
393395
GCC_WARN_UNUSED_VARIABLE = YES;
394-
IPHONEOS_DEPLOYMENT_TARGET = 9.2;
396+
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
395397
MTL_ENABLE_DEBUG_INFO = NO;
396398
SDKROOT = iphoneos;
397399
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
@@ -404,6 +406,7 @@
404406
buildSettings = {
405407
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
406408
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
409+
DEVELOPMENT_TEAM = "";
407410
FRAMEWORK_SEARCH_PATHS = (
408411
"$(inherited)",
409412
"$(PROJECT_DIR)/Frameworks",
@@ -412,8 +415,7 @@
412415
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
413416
PRODUCT_BUNDLE_IDENTIFIER = com.xmartlabs.Example;
414417
PRODUCT_NAME = "$(TARGET_NAME)";
415-
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
416-
SWIFT_VERSION = 4.2;
418+
SWIFT_VERSION = 5.0;
417419
};
418420
name = Debug;
419421
};
@@ -422,6 +424,7 @@
422424
buildSettings = {
423425
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
424426
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
427+
DEVELOPMENT_TEAM = "";
425428
FRAMEWORK_SEARCH_PATHS = (
426429
"$(inherited)",
427430
"$(PROJECT_DIR)/Frameworks",
@@ -430,8 +433,7 @@
430433
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
431434
PRODUCT_BUNDLE_IDENTIFIER = com.xmartlabs.Example;
432435
PRODUCT_NAME = "$(TARGET_NAME)";
433-
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
434-
SWIFT_VERSION = 4.2;
436+
SWIFT_VERSION = 5.0;
435437
};
436438
name = Release;
437439
};
Binary file not shown.

Frameworks/GoogleMapsBase.framework/Modules/module.modulemap

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ framework module GoogleMapsBase {
33
export *
44
module * { export *}
55
link "z"
6+
link framework "CoreFoundation"
67
link framework "CoreLocation"
78
link framework "CoreTelephony"
9+
link framework "CoreText"
810
link framework "Security"}
2.62 MB
Binary file not shown.

Frameworks/GooglePlaces.framework/Headers/GMSAddressComponent.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,17 @@ NS_ASSUME_NONNULL_BEGIN;
1919

2020
/**
2121
* Type of the address component. For a list of supported types, see
22-
* https://developers.google.com/places/ios-api/supported_types#table2. This string will be one
22+
* https://developers.google.com/places/ios-sdk/supported_types#table2. This string will be one
2323
* of the constants defined in GMSPlaceTypes.h.
2424
*/
2525
@property(nonatomic, readonly, copy) NSString *type;
2626

2727
/** Name of the address component, e.g. "Sydney" */
2828
@property(nonatomic, readonly, copy) NSString *name;
2929

30+
/** Short name of the address component, e.g. "AU" */
31+
@property(nonatomic, readonly, copy) NSString *_Nullable shortName;
32+
3033
@end
3134

3235
NS_ASSUME_NONNULL_END;

Frameworks/GooglePlaces.framework/Headers/GMSAutocompleteFetcher.h

+6
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#import "GMSAutocompleteFilter.h"
1818

1919
@class GMSAutocompletePrediction;
20+
@class GMSAutocompleteSessionToken;
2021

2122
NS_ASSUME_NONNULL_BEGIN;
2223

@@ -84,6 +85,11 @@ NS_ASSUME_NONNULL_BEGIN;
8485
/** Filter to apply to autocomplete suggestions (can be nil). */
8586
@property(nonatomic, strong, nullable) GMSAutocompleteFilter *autocompleteFilter;
8687

88+
/**
89+
* Provide a |GMSAutocompleteSessionToken| for tracking the specific autocomplete query flow.
90+
*/
91+
- (void)provideSessionToken:(GMSAutocompleteSessionToken *)sessionToken;
92+
8793
/**
8894
* Notify the fetcher that the source text to autocomplete has changed.
8995
*

Frameworks/GooglePlaces.framework/Headers/GMSAutocompletePrediction.h

+15-4
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,25 @@
99
//
1010

1111

12+
#import <Foundation/Foundation.h>
13+
1214
NS_ASSUME_NONNULL_BEGIN;
1315

16+
#if defined(__IPHONE_11_0) && (__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_11_0)
17+
/**
18+
* Attribute name for match fragments in |GMSAutocompletePrediction| attributedFullText.
19+
*
20+
* @related GMSAutocompletePrediction
21+
*/
22+
extern NSAttributedStringKey const kGMSAutocompleteMatchAttribute;
23+
#else
1424
/**
1525
* Attribute name for match fragments in |GMSAutocompletePrediction| attributedFullText.
1626
*
1727
* @related GMSAutocompletePrediction
1828
*/
1929
extern NSString *const kGMSAutocompleteMatchAttribute;
30+
#endif
2031

2132
/**
2233
* This class represents a prediction of a full query based on a partially typed string.
@@ -68,14 +79,14 @@ extern NSString *const kGMSAutocompleteMatchAttribute;
6879
@property(nonatomic, copy, readonly, nullable) NSAttributedString *attributedSecondaryText;
6980

7081
/**
71-
* An optional property representing the place ID of the prediction, suitable for use in a place
72-
* details request.
82+
* A property representing the place ID of the prediction, suitable for use in a place details
83+
* request.
7384
*/
74-
@property(nonatomic, copy, readonly, nullable) NSString *placeID;
85+
@property(nonatomic, copy, readonly) NSString *placeID;
7586

7687
/**
7788
* The types of this autocomplete result. Types are NSStrings, valid values are any types
78-
* documented at <https://developers.google.com/places/ios-api/supported_types>.
89+
* documented at <https://developers.google.com/places/ios-sdk/supported_types>.
7990
*/
8091
@property(nonatomic, copy, readonly) NSArray<NSString *> *types;
8192

Frameworks/GooglePlaces.framework/Headers/GMSAutocompleteResultsViewController.h

+9-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@
1919
#import "GMSAutocompleteFilter.h"
2020
#import "GMSAutocompletePrediction.h"
2121
#import "GMSPlace.h"
22-
23-
NS_ASSUME_NONNULL_BEGIN;
22+
#import "GMSPlaceFieldMask.h"
2423

2524
@class GMSAutocompleteResultsViewController;
2625

26+
NS_ASSUME_NONNULL_BEGIN;
27+
2728
/**
2829
* Protocol used by |GMSAutocompleteResultsViewController|, to communicate the user's interaction
2930
* with the controller to the application.
@@ -138,6 +139,12 @@ NS_ASSUME_NONNULL_BEGIN;
138139
/** The tint color applied to controls in the Autocomplete view. */
139140
@property(nonatomic, strong, nullable) IBInspectable UIColor *tintColor;
140141

142+
/**
143+
* Specify individual place details to fetch for object |GMSPlace|.
144+
* Defaults to returning all details if not overidden.
145+
*/
146+
@property(nonatomic, assign) GMSPlaceField placeFields;
147+
141148
@end
142149

143150
NS_ASSUME_NONNULL_END;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
//
2+
// GMSAutocompleteSessionToken.h
3+
// Google Places API for iOS
4+
//
5+
// Copyright 2018 Google Inc.
6+
//
7+
// Usage of this SDK is subject to the Google Maps/Google Earth APIs Terms of
8+
// Service: https://developers.google.com/maps/terms
9+
//
10+
11+
12+
#import <Foundation/Foundation.h>
13+
14+
NS_ASSUME_NONNULL_BEGIN;
15+
16+
/**
17+
* This class represents an session token to uniquely identify an series of queries to the Google
18+
* Places API Services for fetching place predictions for a partial search string.
19+
*/
20+
@interface GMSAutocompleteSessionToken : NSObject
21+
@end
22+
23+
NS_ASSUME_NONNULL_END;

Frameworks/GooglePlaces.framework/Headers/GMSAutocompleteTableDataSource.h

+21-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@
1919
#import "GMSAutocompleteFilter.h"
2020
#import "GMSAutocompletePrediction.h"
2121
#import "GMSPlace.h"
22-
23-
NS_ASSUME_NONNULL_BEGIN;
22+
#import "GMSPlaceFieldMask.h"
2423

2524
@class GMSAutocompleteTableDataSource;
2625

26+
NS_ASSUME_NONNULL_BEGIN;
27+
2728
/**
2829
* Protocol used by |GMSAutocompleteTableDataSource|, to communicate the user's interaction with the
2930
* data source to the application.
@@ -147,6 +148,12 @@ NS_ASSUME_NONNULL_BEGIN;
147148
/** The tint color applied to controls in the Autocomplete view. */
148149
@property(nonatomic, strong, nullable) UIColor *tintColor;
149150

151+
/**
152+
* The |GMSPlaceField| for specifying explicit place details to be requested. Default returns
153+
* all avilable fields.
154+
*/
155+
@property(nonatomic, assign) GMSPlaceField placeFields;
156+
150157
/** Designated initializer */
151158
- (instancetype)init NS_DESIGNATED_INITIALIZER;
152159

@@ -162,6 +169,18 @@ NS_ASSUME_NONNULL_BEGIN;
162169
*/
163170
- (void)sourceTextHasChanged:(nullable NSString *)text;
164171

172+
/**
173+
* Clear all predictions.
174+
*
175+
* NOTE: This will call the two delegate methods below:
176+
*
177+
* - |didUpdateAutocompletePredictionsForResultsController:|
178+
* - |didRequestAutocompletePredictionsForResultsController:|
179+
*
180+
* The implementation of this method is guaranteed to call these synchronously and in-order.
181+
*/
182+
- (void)clearResults;
183+
165184
@end
166185

167186
NS_ASSUME_NONNULL_END;

Frameworks/GooglePlaces.framework/Headers/GMSAutocompleteViewController.h

+9-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@
1919
#import "GMSAutocompleteFilter.h"
2020
#import "GMSAutocompletePrediction.h"
2121
#import "GMSPlace.h"
22-
23-
NS_ASSUME_NONNULL_BEGIN;
22+
#import "GMSPlaceFieldMask.h"
2423

2524
@class GMSAutocompleteViewController;
2625

26+
NS_ASSUME_NONNULL_BEGIN;
27+
2728
/**
2829
* Protocol used by |GMSAutocompleteViewController|, to communicate the user's interaction
2930
* with the controller to the application.
@@ -153,6 +154,12 @@ NS_ASSUME_NONNULL_BEGIN;
153154
/** The tint color applied to controls in the Autocomplete view. */
154155
@property(nonatomic, strong, nullable) IBInspectable UIColor *tintColor;
155156

157+
/**
158+
* Specify individual place details to fetch for object |GMSPlace|.
159+
* Defaults to returning all details if not overidden.
160+
*/
161+
@property(nonatomic, assign) GMSPlaceField placeFields;
162+
156163
@end
157164

158165
NS_ASSUME_NONNULL_END;

0 commit comments

Comments
 (0)