read symbols from symbol stream when creating assembly defn

Author: Lordfirespeed

NetcodePatcher/CodeGen/NetcodeILPPApplicator.cs

@@ -133,13 +133,13 @@ public void ApplyProcesses()
             assembly = ApplyProcess<INetworkMessageILPP>(assembly);
             assembly = ApplyProcess<INetworkSerializableILPP>(assembly);
             assembly = ApplyProcess<ApplyPatchedAttributeILPP>(assembly);
-
-            var outputAssemblyName = Path.GetFileNameWithoutExtension(OutputPath);
-            var outputDirectoryName = Path.GetDirectoryName(OutputPath)!;
-            var outputPdbPath = Path.Combine(outputDirectoryName, $"{outputAssemblyName}.pdb");
 
             if (!debugSymbolsAreEmbedded)
             {
+                var outputAssemblyName = Path.GetFileNameWithoutExtension(OutputPath);
+                var outputDirectoryName = Path.GetDirectoryName(OutputPath)!;
+                var outputPdbPath = Path.Combine(outputDirectoryName, $"{outputAssemblyName}.pdb");
+                
                 // save the weaved assembly to file.
                 // some tests open it and check for certain IL code.
                 File.WriteAllBytes(OutputPath, assembly.InMemoryAssembly.PeData);
@@ -150,11 +150,14 @@ public void ApplyProcesses()
             using var peStream = new MemoryStream(assembly.InMemoryAssembly.PeData);
             using var symbolStream = new MemoryStream(assembly.InMemoryAssembly.PdbData);
 
-            var assemblyDefinition = AssemblyDefinition.ReadAssembly(peStream);
+            var assemblyDefinition = AssemblyDefinition.ReadAssembly(peStream, new ReaderParameters()
+            {
+                ReadSymbols = true,
+                SymbolStream = symbolStream
+            });
 
-            assemblyDefinition.Write(OutputPath , new WriterParameters
+            assemblyDefinition.Write(OutputPath, new WriterParameters
             {
-                SymbolStream = symbolStream,
                 WriteSymbols = true
             });