fix(lens): canon lens detecton should be independent of locale #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassec
force-pushed
the
canon_lens_tests
branch
3 times, most recently
from
5107f9d
to
1f1a995
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
=======================================
Coverage 64.57% 64.57%
=======================================
Files 104 104
Lines 22196 22207 +11
Branches 10882 10889 +7
=======================================
+ Hits 14332 14341 +9
- Misses 5622 5623 +1
- Partials 2242 2243 +1 ☔ View full report in Codecov by Sentry. |
hassec
force-pushed
the
canon_lens_tests
branch
from
1f1a995
to
6565352
Compare
kmilos
reviewed
Mar 29, 2024
kmilos
reviewed
Mar 29, 2024
kmilos
reviewed
Mar 29, 2024
kmilos
approved these changes
Mar 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::stofby a locale independent string-> float alternative.localebased regressions in the canon lens detection. But exiv2 could probably benefit from a more global test. Something for the exiv2 maintainer team to consider.Closes #2746