Tags - Nothing happens after clicking Import tags

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.19-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77913
Email or phone of affected tester (no customers): sdhiubsdhishiushduis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has multi-level tags.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Click More > Import spreadsheet.
4. Click Multi-level tags.
5. Click Import tags.

Expected Result:

Import page will open.

Actual Result:

Nothing happens after clicking Import tags.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7077212_1771009537623.1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #77913

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #77913 - "fix: refactor ConfirmModal usage to useConfirmModal in workspace tags pages" by @daledah (High confidence)
Related Issues: None

Recommendation: REVERT

The bug is a straightforward async/await issue introduced during the refactor. Reverting PR #77913 is the safest option to unblock the deploy immediately. The PR author can then fix the bug and resubmit.

Labels: No label changes needed - this is a Frontend bug, so DeployBlockerCash should remain.

Detailed Analysis

Evidence

The bug report states that clicking "Import tags" on the multi-level tags option does nothing. I traced this to a missing async keyword in the ImportTagsOptionsPage.tsx file.

PR #77913 refactored the code to use useConfirmModal hook instead of the ConfirmModal component. During this refactor, the "Multi-level tags" button's onPress handler was changed but the async keyword was omitted.

Verification

File affected: /home/runner/_work/App/App/src/pages/workspace/tags/ImportTagsOptionsPage.tsx

Current code at line 278 (introduced by PR #77913):

onPress={() => {
    if (!isControlPolicy(policy)) {
        setShouldRunPostUpgradeFlow(true);
        Navigation.navigate(...);
        return;
    }
    startMultiLevelTagImportFlow();  // <-- async function NOT being awaited
}}

Comparison - Single level button at line 242 (correctly implemented in same PR):

onPress={async () => {  // <-- async keyword present
    setImportedSpreadsheetIsImportingMultiLevelTags(false);
    if (hasVisibleTags && isMultiLevelTags) {
        const {action} = await showConfirmModal({...});  // <-- properly awaited
        ...
    }
}}

Root Cause

The startMultiLevelTagImportFlow() function (line 155) is an async function that uses await showConfirmModal() to display a confirmation modal and wait for user action. However, the "Multi-level tags" button's onPress handler is NOT async and does not await the call to startMultiLevelTagImportFlow().

When the user clicks the button:

1. The onPress handler calls startMultiLevelTagImportFlow()
2. The function starts executing and calls await showConfirmModal()
3. BUT the onPress handler returns immediately without waiting
4. The Promise from showConfirmModal() is never resolved in the context of the handler
5. The navigation code after the modal confirmation never executes

The fix is simple: change line 278 from onPress={() => { to onPress={async () => { OR await the call: await startMultiLevelTagImportFlow();

Why This Works on Single Level

The "Single level" button at line 242 was correctly implemented with async in the same PR, which is why it works. Only the "Multi-level tags" button has this bug.