[BUG] Wrong error when trying to enable Travel invoicing without a settlement account

[rlinoz]

https://expensify.slack.com/archives/C05S5EV2JTX/p1771531665091999?thread_ts=1771528962.822579&cid=C05S5EV2JTX

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user tries to enable Travel Invoicing (Central invoicing toggle) and the backend rejects the request with a specific error (e.g. "Travel Invoicing not configured. Please set up a USD settlement account first."), the UI displays a generic "Oops... something went wrong and your request could not be completed. Please try again later." instead of the actual server error message.

What is the root cause of that problem?

The toggleTravelInvoicing function hardcodes 'common.genericErrorMessage' in its client-side failureData, which is always applied when the API returns a non-200 response.

App/src/libs/actions/TravelInvoicing.ts

Line 291 in e611de9

errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),

The server does return the actual error message in response.message, but it sends back an empty onyxData: [] array, so no server-side error is written to Onyx. Meanwhile, the Onyx update pipeline in applyHTTPSOnyxUpdates applies response.onyxData first and then request.failureData second, meaning even if the server did send error data via onyxData, the client's hardcoded generic error in failureData would overwrite it.

App/src/libs/actions/OnyxUpdates.ts

Lines 42 to 67 in e611de9

	const onyxDataUpdatePromise = response.onyxData ? updateHandler(response.onyxData) : Promise.resolve();
	return onyxDataUpdatePromise
	.then(() => {
	// Handle the request's success/failure data (client-side data)
	if (response.jsonCode === 200 && request.successData) {
	return updateHandler(request.successData);
	}
	if (response.jsonCode !== 200 && request.failureData) {
	// 460 jsonCode in Expensify world means "admin required".
	// Typically, this would only happen if a user attempts an API command that requires policy admin access when they aren't an admin.
	// In this case, we don't want to apply failureData because it will likely result in a RedBrickRoad error on a policy field which is not accessible.
	// Meaning that there's a red dot you can't dismiss.
	if (response.jsonCode === 460) {
	Log.info('[OnyxUpdateManager] Received 460 status code, not applying failure data');
	return Promise.resolve();
	}
	trackExpenseApiError({
	command: request.command,
	jsonCode: response.jsonCode ?? 0,
	message: response.message,
	requestData: request.data,
	});
	return updateHandler(request.failureData);

What changes do you think we should make in order to solve the problem?

1. Remove the errors field from toggleTravelInvoicing's failureData so it no longer overwrites server-provided error messages. The failureData should still revert UI state (isEnabled, pendingAction) but should not set any error — that responsibility belongs to the backend via onyxData.
   

   App/src/libs/actions/TravelInvoicing.ts

   Lines 280 to 295 in e611de9

   	// On failure: revert isEnabled and show error
   	const failureData: OnyxUpdate[] = [
   	{
   	onyxMethod: Onyx.METHOD.MERGE,
   	key: cardSettingsKey,
   	value: {
   	isEnabled: !enabled,
   	[CONST.TRAVEL.PROGRAM_TRAVEL_US]: {
   	isEnabled: !enabled,
   	},
   	pendingAction: null,
   	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
   	},
   	},
   	];

--- a/src/libs/actions/TravelInvoicing.ts
+++ b/src/libs/actions/TravelInvoicing.ts
@@ -280,14 +280,12 @@
     // On failure: revert isEnabled and show error
     const failureData: OnyxUpdate[] = [
         {
             onyxMethod: Onyx.METHOD.MERGE,
             key: cardSettingsKey,
             value: {
                 isEnabled: !enabled,
                 [CONST.TRAVEL.PROGRAM_TRAVEL_US]: {
                     isEnabled: !enabled,
                 },
                 pendingAction: null,
-                errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
             },
         },
     ];

2. The backend ToggleTravelInvoicing endpoint should be updated to return the actual error message via onyxData instead of returning an empty array. This way, when the API responds with a 400, the specific error (e.g. "Please set up a USD settlement account first") will be written to Onyx and displayed in the UI. Since onyxData is applied before failureData, and failureData no longer sets errors, the server error will be preserved.

What alternative solutions did you explore? (Optional)

[ishpaul777]

@MelvinBot as part of this issue we need to do 2 thing first remove error field from failure data and move the public domain check before disable toggle, below are diffs please create PR and assign me as reviewer

diff --git a/src/libs/actions/TravelInvoicing.ts b/src/libs/actions/TravelInvoicing.ts
index 563afc05da7..c0d31587e16 100644
--- a/src/libs/actions/TravelInvoicing.ts
+++ b/src/libs/actions/TravelInvoicing.ts
@@ -288,7 +288,6 @@ function toggleTravelInvoicing(policyID: string, workspaceAccountID: number, ena
                     isEnabled: !enabled,
                 },
                 pendingAction: null,
-                errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
             },
         },
     ];
diff --git a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
index a2486c9e34e..faad6eb8e16 100644
--- a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
+++ b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
@@ -115,6 +115,12 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
      * When turning OFF: show confirmation modal, then call toggleTravelInvoicing(false).
      */
     const handleToggle = (isEnabled: boolean) => {
+        // Check if user is on a public domain - Travel Invoicing requires a private domain
+        if (account?.isFromPublicDomain) {
+            Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
+            return;
+        }
+
         if (!isEnabled) {
             // Trying to disable - check for outstanding balance first
             if (hasOutstandingTravelBalance(cardSettings)) {
@@ -127,12 +133,6 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
             return;
         }
 
-        // Check if user is on a public domain - Travel Invoicing requires a private domain
-        if (account?.isFromPublicDomain) {
-            Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
-            return;
-        }
-
         // Turning ON - check if bank account setup is needed first
         if (!eligibleBankAccounts.length || isSetupUnfinished) {
             // No bank accounts - start add bank account flow

[MelvinBot]

🤖 Draft PR created: #83095
Please mark it as "Ready for review" when it is ready for review.