Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First empty line in code block is not styled #641

Open
OzymandiasTheGreat opened this issue Mar 11, 2025 · 5 comments
Open

First empty line in code block is not styled #641

OzymandiasTheGreat opened this issue Mar 11, 2025 · 5 comments

Comments

@OzymandiasTheGreat
Copy link

With text value set to \n and markdown ranges set to [{ type: "pre", start: 0, length: 1 }] there's no visible styling. Adding another new line and extending the range, second line is styled correctly.

Context: I'm implementing a WYSIWYG rich text editor on top of live-markdown and when toggling code block there's no visual indication if it's the first line. Once the user starts typing styling is applied correctly, so this isn't a blocker.

@tomekzaw
Copy link
Collaborator

Hi @OzymandiasTheGreat, thanks for reporting this issue.

I'm afraid newlines can't be styled that easily.

What platform does this issue report refer to?

@OzymandiasTheGreat
Copy link
Author

This happens on iOS (simulator).
For some reason I didn't think to try on Android, I'll try and report back.

@OzymandiasTheGreat
Copy link
Author

Apparently empty lines in a code block aren't styled at all on Android, regardless of whether it's the first line or not.
I'll have to test on Android more often.

@tomekzaw
Copy link
Collaborator

Apparently empty lines in a code block aren't styled at all on Android, regardless of whether it's the first line or not.

Yes, that's correct, the background color is applied only under text, not under the whole block as a rectangle. There are no characters in an empty line so there's no background.

Image

@tomekzaw
Copy link
Collaborator

There's a PR by @maksg that should add proper background underneath codeblocks but it has been abandoned for quite some time now: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants