From 06fd71e462ab9637decbabaed048823b08ba5834 Mon Sep 17 00:00:00 2001 From: Tomek Zawadzki Date: Fri, 13 Sep 2024 17:34:02 +0200 Subject: [PATCH] Move `OwningShadowNodeFragment` to a separate file --- .../MarkdownTextInputDecoratorShadowNode.cpp | 3 -- .../MarkdownTextInputDecoratorShadowNode.h | 16 +--------- .../OwningShadowNodeFragment.h | 31 +++++++++++++++++++ 3 files changed, 32 insertions(+), 18 deletions(-) create mode 100644 cpp/react/renderer/components/RNLiveMarkdownSpec/OwningShadowNodeFragment.h diff --git a/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp b/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp index ae56126d..7d38ec2a 100644 --- a/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp +++ b/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp @@ -1,8 +1,5 @@ #if defined(RCT_NEW_ARCH_ENABLED) || defined(ANDROID) -#include - -#include "MarkdownShadowFamilyRegistry.h" #include "MarkdownTextInputDecoratorShadowNode.h" using namespace expensify::livemarkdown; diff --git a/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.h b/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.h index 3392d557..611294ab 100644 --- a/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.h +++ b/cpp/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.h @@ -3,7 +3,7 @@ #include "MarkdownShadowFamilyRegistry.h" #include "MarkdownTextInputDecoratorState.h" -#include +#include "OwningShadowNodeFragment.h" #include #include #include @@ -13,20 +13,6 @@ using namespace expensify::livemarkdown; namespace facebook { namespace react { -struct OwningShadowNodeFragment { - Props::Shared props; - ShadowNode::SharedListOfShared children; - State::Shared state; - - operator ShadowNodeFragment() const { - return ShadowNodeFragment { - .props = props, - .children = children, - .state = state - }; - } -}; - JSI_EXPORT extern const char MarkdownTextInputDecoratorViewComponentName[]; class JSI_EXPORT MarkdownTextInputDecoratorShadowNode final diff --git a/cpp/react/renderer/components/RNLiveMarkdownSpec/OwningShadowNodeFragment.h b/cpp/react/renderer/components/RNLiveMarkdownSpec/OwningShadowNodeFragment.h new file mode 100644 index 00000000..80233f99 --- /dev/null +++ b/cpp/react/renderer/components/RNLiveMarkdownSpec/OwningShadowNodeFragment.h @@ -0,0 +1,31 @@ +#pragma once +#if defined(RCT_NEW_ARCH_ENABLED) || defined(ANDROID) + +#include +#include +#include +#include + +using namespace facebook::react; + +namespace expensify { +namespace livemarkdown { + +struct OwningShadowNodeFragment { + Props::Shared props; + ShadowNode::SharedListOfShared children; + State::Shared state; + + operator ShadowNodeFragment() const { + return ShadowNodeFragment { + .props = props, + .children = children, + .state = state + }; + } +}; + +} // namespace livemarkdown +} // namespace expensify + +#endif